From 7867feac6ab69672ea14567fa5d7aee4390e8243 Mon Sep 17 00:00:00 2001 From: Rob Austin Date: Tue, 29 Jul 2014 14:28:43 +0100 Subject: [PATCH] HCOLL-119 for consistance renamed it to VanillaSharedReplicatedHashMap --- .../openhft/chronicle/map/package-info.java | 4 --- .../collections/ChronicleReplicatedMap.java | 35 ------------------- .../collections/ConcurrentHashMap2.java | 25 ------------- .../collections/SharedHashMapBuilder.java | 10 +++--- ...va => VanillaSharedReplicatedHashMap.java} | 24 ++++++------- 5 files changed, 17 insertions(+), 81 deletions(-) delete mode 100644 src/main/java/net/openhft/chronicle/map/package-info.java delete mode 100644 src/main/java/net/openhft/collections/ChronicleReplicatedMap.java delete mode 100644 src/main/java/net/openhft/collections/ConcurrentHashMap2.java rename src/main/java/net/openhft/collections/{VanillaSharedReplicatedMap.java => VanillaSharedReplicatedHashMap.java} (98%) diff --git a/src/main/java/net/openhft/chronicle/map/package-info.java b/src/main/java/net/openhft/chronicle/map/package-info.java deleted file mode 100644 index cf8f0abba..000000000 --- a/src/main/java/net/openhft/chronicle/map/package-info.java +++ /dev/null @@ -1,4 +0,0 @@ -/** - * Created by peter on 18/07/14. - */ -package net.openhft.chronicle.map; \ No newline at end of file diff --git a/src/main/java/net/openhft/collections/ChronicleReplicatedMap.java b/src/main/java/net/openhft/collections/ChronicleReplicatedMap.java deleted file mode 100644 index ed6312de6..000000000 --- a/src/main/java/net/openhft/collections/ChronicleReplicatedMap.java +++ /dev/null @@ -1,35 +0,0 @@ -/* - * Copyright 2014 Higher Frequency Trading - *

- * http://www.higherfrequencytrading.com - *

- * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - *

- * http://www.apache.org/licenses/LICENSE-2.0 - *

- * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package net.openhft.collections; - -import net.openhft.chronicle.map.ChronicleMap; -import org.jetbrains.annotations.NotNull; - -import java.io.IOException; - -/** - * @author Rob Austin. - */ -public class ChronicleReplicatedMap extends VanillaSharedReplicatedMap implements ChronicleMap { - - public ChronicleReplicatedMap(@NotNull SharedHashMapBuilder builder, @NotNull Class aClass, @NotNull Class aClass2) throws IOException { - super(builder, aClass, aClass2); - } - -} diff --git a/src/main/java/net/openhft/collections/ConcurrentHashMap2.java b/src/main/java/net/openhft/collections/ConcurrentHashMap2.java deleted file mode 100644 index 07611ecac..000000000 --- a/src/main/java/net/openhft/collections/ConcurrentHashMap2.java +++ /dev/null @@ -1,25 +0,0 @@ -/* - * Copyright 2014 Higher Frequency Trading - *

- * http://www.higherfrequencytrading.com - *

- * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - *

- * http://www.apache.org/licenses/LICENSE-2.0 - *

- * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package net.openhft.collections; - -/** - * @author Rob Austin. - */ -public interface ConcurrentHashMap2 { -} diff --git a/src/main/java/net/openhft/collections/SharedHashMapBuilder.java b/src/main/java/net/openhft/collections/SharedHashMapBuilder.java index 1d2a89f71..f2bc1add6 100644 --- a/src/main/java/net/openhft/collections/SharedHashMapBuilder.java +++ b/src/main/java/net/openhft/collections/SharedHashMapBuilder.java @@ -297,8 +297,8 @@ public class SharedHashMapBuilder implements Cloneable { if (identifier <= 0) throw new IllegalArgumentException("Identifier must be positive, " + identifier + " given"); - final VanillaSharedReplicatedMap result = - new VanillaSharedReplicatedMap(builder, kClass, vClass); + final VanillaSharedReplicatedHashMap result = + new VanillaSharedReplicatedHashMap(builder, kClass, vClass); if (externalReplicatorBuilder != null) externalReplicator = applyExternalReplicator(result, externalReplicatorBuilder, kClass, vClass); @@ -617,7 +617,7 @@ public class SharedHashMapBuilder implements Cloneable { ExternalReplicator.AbstractExternalReplicator applyExternalReplicator - (VanillaSharedReplicatedMap map, + (VanillaSharedReplicatedHashMap map, ExternalReplicatorBuilder builder, Class kClass, Class vClass) { @@ -654,7 +654,7 @@ public class SharedHashMapBuilder implements Cloneable { } - void applyUdpReplication(VanillaSharedReplicatedMap result, + void applyUdpReplication(VanillaSharedReplicatedHashMap result, UdpReplicatorBuilder udpReplicatorBuilder) throws IOException { @@ -678,7 +678,7 @@ public class SharedHashMapBuilder implements Cloneable { } - void applyTcpReplication(@NotNull VanillaSharedReplicatedMap result, + void applyTcpReplication(@NotNull VanillaSharedReplicatedHashMap result, @NotNull TcpReplicatorBuilder tcpReplicatorBuilder) throws IOException { diff --git a/src/main/java/net/openhft/collections/VanillaSharedReplicatedMap.java b/src/main/java/net/openhft/collections/VanillaSharedReplicatedHashMap.java similarity index 98% rename from src/main/java/net/openhft/collections/VanillaSharedReplicatedMap.java rename to src/main/java/net/openhft/collections/VanillaSharedReplicatedHashMap.java index c8ad1e042..7512cf612 100644 --- a/src/main/java/net/openhft/collections/VanillaSharedReplicatedMap.java +++ b/src/main/java/net/openhft/collections/VanillaSharedReplicatedHashMap.java @@ -80,13 +80,13 @@ import static net.openhft.lang.collection.DirectBitSet.NOT_FOUND; * @param the entries key type * @param the entries value type */ -class VanillaSharedReplicatedMap extends AbstractVanillaSharedHashMap +class VanillaSharedReplicatedHashMap extends AbstractVanillaSharedHashMap implements ChronicleMap, ReplicaExternalizable, EntryResolver, Closeable { static final int MAX_UNSIGNED_SHORT = Character.MAX_VALUE; - private static final Logger LOG = LoggerFactory.getLogger(VanillaSharedReplicatedMap.class); + private static final Logger LOG = LoggerFactory.getLogger(VanillaSharedReplicatedHashMap.class); private static final int LAST_UPDATED_HEADER_SIZE = (127 * 8); // for file, jdbc and UDP replication @@ -102,9 +102,9 @@ class VanillaSharedReplicatedMap extends AbstractVanillaSharedHashMap kClass, - @NotNull Class vClass) throws IOException { + public VanillaSharedReplicatedHashMap(@NotNull SharedHashMapBuilder builder, + @NotNull Class kClass, + @NotNull Class vClass) throws IOException { super(builder, kClass, vClass); this.timeProvider = builder.timeProvider(); @@ -868,7 +868,7 @@ class VanillaSharedReplicatedMap extends AbstractVanillaSharedHashMap= timeStamp && - entry.readByte() == VanillaSharedReplicatedMap.this.identifier()) + entry.readByte() == VanillaSharedReplicatedHashMap.this.identifier()) callback.set(index, pos); } }); @@ -887,7 +887,7 @@ class VanillaSharedReplicatedMap extends AbstractVanillaSharedHashMap extends AbstractVanillaSharedHashMap extends AbstractVanillaSharedHashMap map, Bytes entry, int metaDataBytes, boolean added, K key, V value, long pos, SharedSegment segment) { - assert VanillaSharedReplicatedMap.this == map : + assert VanillaSharedReplicatedHashMap.this == map : "ModificationIterator.onPut() is called from outside of the parent map"; try { nextListener.onPut(map, entry, metaDataBytes, added, key, value, pos, segment); @@ -1161,7 +1161,7 @@ class VanillaSharedReplicatedMap extends AbstractVanillaSharedHashMap map, Bytes entry, int metaDataBytes, K key, V value, int pos, SharedSegment segment) { - assert VanillaSharedReplicatedMap.this == map : + assert VanillaSharedReplicatedHashMap.this == map : "ModificationIterator.onRemove() is called from outside of the parent map"; try { nextListener.onRemove(map, entry, metaDataBytes, key, value, pos, segment); @@ -1255,7 +1255,7 @@ class VanillaSharedReplicatedMap extends AbstractVanillaSharedHashMap map, Bytes entry, int metaDataBytes, boolean added, K key, V value, long pos, SharedSegment segment) { - assert VanillaSharedReplicatedMap.this == map : + assert VanillaSharedReplicatedHashMap.this == map : "ModificationIterator.onPut() is called from outside of the parent map"; @@ -1269,7 +1269,7 @@ class VanillaSharedReplicatedMap extends AbstractVanillaSharedHashMap map, Bytes entry, int metaDataBytes, K key, V value, int pos, SharedSegment segment) { - assert VanillaSharedReplicatedMap.this == map : + assert VanillaSharedReplicatedHashMap.this == map : "ModificationIterator.onRemove() is called from outside of the parent map";