From 7bf391c560ea9a84faf9a090a28cb33c9065f5ee Mon Sep 17 00:00:00 2001 From: Rob Austin Date: Mon, 2 Feb 2015 11:27:12 +0000 Subject: [PATCH] Please dont change this code back with out first running - at net.openhft.chronicle.map.ReplicatedChronicleMapTest.testPut1_NullPointerException(ReplicatedChronicleMapTest.java:489), see java.lang.IllegalArgumentException: Argument for @NotNull parameter 'key' of net/openhft/chronicle/map/ReplicatedChronicleMap.put1 must not be null at net.openhft.chronicle.map.ReplicatedChronicleMap.put1(ReplicatedChronicleMap.java) at net.openhft.chronicle.map.VanillaChronicleMap.put(VanillaChronicleMap.java:532) at net.openhft.chronicle.map.ReplicatedChronicleMapTest.testPut1_NullPointerException(ReplicatedChronicleMapTest.java:489) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.junit.runners.Suite.runChild(Suite.java:127) at org.junit.runners.Suite.runChild(Suite.java:26) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.junit.runner.JUnitCore.run(JUnitCore.java:160) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:67) --- .../java/net/openhft/chronicle/map/VanillaChronicleMap.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/net/openhft/chronicle/map/VanillaChronicleMap.java b/src/main/java/net/openhft/chronicle/map/VanillaChronicleMap.java index 5ef931fa1..6c0147f99 100755 --- a/src/main/java/net/openhft/chronicle/map/VanillaChronicleMap.java +++ b/src/main/java/net/openhft/chronicle/map/VanillaChronicleMap.java @@ -539,7 +539,9 @@ class VanillaChronicleMap, return put1(key, value, false); } - V put1(@net.openhft.lang.model.constraints.NotNull K key, V value, boolean replaceIfPresent) { + V put1( K key, V value, boolean replaceIfPresent) { + if (key == null) + throw new NullPointerException(); checkKey(key); checkValue(value); ThreadLocalCopies copies = keyInteropProvider.getCopies(null);