From 9d3ff930215fb2309cd8ee26c8349eb39e6b7c29 Mon Sep 17 00:00:00 2001 From: leventov Date: Sat, 3 Oct 2015 05:07:36 +0300 Subject: [PATCH] Default removedEntryCleanupTimeout() 1 second -> 1 minute --- .../net/openhft/chronicle/hash/ChronicleHashBuilder.java | 2 +- .../net/openhft/chronicle/map/ChronicleMapBuilder.java | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/openhft/chronicle/hash/ChronicleHashBuilder.java b/src/main/java/net/openhft/chronicle/hash/ChronicleHashBuilder.java index 3f488f4b2..c46562886 100755 --- a/src/main/java/net/openhft/chronicle/hash/ChronicleHashBuilder.java +++ b/src/main/java/net/openhft/chronicle/hash/ChronicleHashBuilder.java @@ -411,7 +411,7 @@ public interface ChronicleHashBuilder, * entry completely from the data structure. This timeout should depend on your distributed * system topology, and typical replication latencies, that should be determined experimentally. * - *

Default timeout is 1 second. + *

Default timeout is 1 minute. * * @param removedEntryCleanupTimeout timeout, after which stale removed entries could be erased * from Chronicle Hash data structure completely diff --git a/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java b/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java index 7fcbc0250..7ec45e8c2 100755 --- a/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java +++ b/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java @@ -181,9 +181,15 @@ public final class ChronicleMapBuilder implements // replication private TimeProvider timeProvider = MicrosecondPrecisionSystemTimeProvider.instance(); + /** + * Default timeout is 1 minute. Even loopback tests converge often in the course of seconds, + * let alone WAN replication over many nodes might take tens of seconds. + * + * TODO review + */ long cleanupTimeout = 1; + TimeUnit cleanupTimeoutUnit = TimeUnit.MINUTES; private boolean cleanupRemovedEntries = true; - TimeUnit cleanupTimeoutUnit = TimeUnit.SECONDS; private BytesMarshallerFactory bytesMarshallerFactory; private ObjectSerializer objectSerializer;