From a11f79f798f1c69031ad307f5f4a4e14e3983cce Mon Sep 17 00:00:00 2001
From: leventov <leventov@ya.ru>
Date: Mon, 14 Dec 2015 18:49:47 +0300
Subject: [PATCH] Remove map persistence file locking, as unnecessary

---
 .../chronicle/hash/impl/VanillaChronicleHash.java   | 13 ++++++-------
 .../openhft/chronicle/map/ChronicleMapBuilder.java  |  9 +++------
 2 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/src/main/java/net/openhft/chronicle/hash/impl/VanillaChronicleHash.java b/src/main/java/net/openhft/chronicle/hash/impl/VanillaChronicleHash.java
index 438ec63cf..3243bc158 100644
--- a/src/main/java/net/openhft/chronicle/hash/impl/VanillaChronicleHash.java
+++ b/src/main/java/net/openhft/chronicle/hash/impl/VanillaChronicleHash.java
@@ -41,7 +41,6 @@ import org.slf4j.LoggerFactory;
 import java.io.*;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
-import java.nio.channels.FileLock;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.TimeUnit;
@@ -816,12 +815,12 @@ public abstract class VanillaChronicleHash<K,
         long minFileSize = mappingOffsetInFile + mapSize;
         FileChannel fileChannel = raf.getChannel();
         if (fileChannel.size() < minFileSize) {
-            // handle a possible race condition between processes.
-            try (FileLock ignored = fileChannel.lock()) {
-                if (fileChannel.size() < minFileSize) {
-                    raf.setLength(minFileSize);
-                }
-            }
+            // In MappedFile#acquireByteStore(), this is wrapped with fileLock(), to avoid race
+            // condition between processes. This map() method is called either when a new tier is
+            // allocated (in this case concurrent access is mutually excluded by
+            // globalMutableStateLock), or on map creation, when race condition should be excluded
+            // by self-bootstrapping header spec
+            raf.setLength(minFileSize);
         }
         long address = OS.map(fileChannel, READ_WRITE, mappingOffsetInFile, mapSize);
         OS.Unmapper unmapper = new OS.Unmapper(address, mapSize, DUMMY_REFERENCE_COUNTED);
diff --git a/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java b/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java
index ee48aed28..df7911232 100755
--- a/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java
+++ b/src/main/java/net/openhft/chronicle/map/ChronicleMapBuilder.java
@@ -43,7 +43,6 @@ import org.slf4j.LoggerFactory;
 import java.io.*;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
-import java.nio.channels.FileLock;
 import java.util.*;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
@@ -1439,12 +1438,10 @@ public final class ChronicleMapBuilder<K, V> implements
 
             int headerSize = (int) headerBytes.writePosition();
             headerBuffer.limit(headerSize);
-            try (FileLock ignored = fileChannel.lock(0, headerSize, false)) {
-                while (headerBuffer.remaining() > 0) {
-                    fileChannel.write(headerBuffer, headerBuffer.position());
-                }
-                map.initBeforeMapping(fileChannel, headerSize);
+            while (headerBuffer.remaining() > 0) {
+                fileChannel.write(headerBuffer, headerBuffer.position());
             }
+            map.initBeforeMapping(fileChannel, headerSize);
             map.createMappedStoreAndSegments(file, raf);
         }