From 02d754e0ee25648c5d785e34832c8dc5df23290a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=AB=98=E9=93=81?= Date: Sat, 12 Dec 2020 13:56:37 +0800 Subject: [PATCH] bug fix schema stat, fix #4067 --- .../druid/sql/visitor/SchemaStatVisitor.java | 1 - .../com/alibaba/druid/bvt/bug/Issue4067.java | 22 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 src/test/java/com/alibaba/druid/bvt/bug/Issue4067.java diff --git a/src/main/java/com/alibaba/druid/sql/visitor/SchemaStatVisitor.java b/src/main/java/com/alibaba/druid/sql/visitor/SchemaStatVisitor.java index 92cc80ab3b..b9ea581cda 100644 --- a/src/main/java/com/alibaba/druid/sql/visitor/SchemaStatVisitor.java +++ b/src/main/java/com/alibaba/druid/sql/visitor/SchemaStatVisitor.java @@ -2759,7 +2759,6 @@ public class SchemaStatVisitor extends SQLASTVisitorAdapter { SQLName tableName = x.getObject(); TableStat tableStat = this.getTableStat(x.getObject()); - tableStat.incrementDropIndexCount(); SQLName column = x.getColumn(); if (column != null) { diff --git a/src/test/java/com/alibaba/druid/bvt/bug/Issue4067.java b/src/test/java/com/alibaba/druid/bvt/bug/Issue4067.java new file mode 100644 index 0000000000..26eda698a8 --- /dev/null +++ b/src/test/java/com/alibaba/druid/bvt/bug/Issue4067.java @@ -0,0 +1,22 @@ +package com.alibaba.druid.bvt.bug; + +import java.util.List; + +import com.alibaba.druid.DbType; +import com.alibaba.druid.sql.SQLUtils; +import com.alibaba.druid.sql.ast.SQLStatement; +import com.alibaba.druid.sql.visitor.SchemaStatVisitor; +import com.alibaba.druid.stat.TableStat; +import junit.framework.TestCase; + +public class Issue4067 extends TestCase { + public void test_for_issue() throws Exception { + List stmtList = SQLUtils.parseStatements("desc bi.aaa", DbType.hive); + SQLStatement stmt = stmtList.get(0); + SchemaStatVisitor statVisitor = SQLUtils.createSchemaStatVisitor(DbType.hive); + stmt.accept(statVisitor); + assertEquals(1, statVisitor.getTables().size()); + TableStat tableStat = statVisitor.getTableStat("bi.aa"); + assertEquals(0, tableStat.getDropIndexCount()); + } +}