From 1d66501ffe7f48ca26a2685e3a6c77b01de67c3f Mon Sep 17 00:00:00 2001 From: bucketli Date: Thu, 9 Apr 2015 14:36:45 +0800 Subject: [PATCH] fix not support ALTER TABLE XXX ADD KEY xxx('xxx') --- .../ast/statement/SQLAlterTableAddIndex.java | 10 ++++ .../mysql/parser/MySqlStatementParser.java | 6 ++- .../druid/sql/parser/SQLStatementParser.java | 12 ++++- .../sql/visitor/SQLASTOutputVisitor.java | 3 +- .../bvt/sql/mysql/MySqlAlterTableTest19.java | 46 +++++++++++++++++++ 5 files changed, 74 insertions(+), 3 deletions(-) create mode 100644 src/test/java/com/alibaba/druid/bvt/sql/mysql/MySqlAlterTableTest19.java diff --git a/src/main/java/com/alibaba/druid/sql/ast/statement/SQLAlterTableAddIndex.java b/src/main/java/com/alibaba/druid/sql/ast/statement/SQLAlterTableAddIndex.java index b14e64a473..1c5650ffba 100644 --- a/src/main/java/com/alibaba/druid/sql/ast/statement/SQLAlterTableAddIndex.java +++ b/src/main/java/com/alibaba/druid/sql/ast/statement/SQLAlterTableAddIndex.java @@ -20,6 +20,7 @@ import java.util.List; import com.alibaba.druid.sql.ast.SQLName; import com.alibaba.druid.sql.ast.SQLObjectImpl; +import com.alibaba.druid.sql.parser.Token; import com.alibaba.druid.sql.visitor.SQLASTVisitor; public class SQLAlterTableAddIndex extends SQLObjectImpl implements SQLAlterTableItem { @@ -33,6 +34,8 @@ public class SQLAlterTableAddIndex extends SQLObjectImpl implements SQLAlterTabl private String type; private String using; + + private String keyOrIndex = Token.INDEX.name; @Override protected void accept0(SQLASTVisitor visitor) { @@ -79,4 +82,11 @@ public class SQLAlterTableAddIndex extends SQLObjectImpl implements SQLAlterTabl this.using = using; } + public String getKeyOrIndex() { + return keyOrIndex; + } + + public void setKeyOrIndex(String keyOrIndex) { + this.keyOrIndex = keyOrIndex; + } } diff --git a/src/main/java/com/alibaba/druid/sql/dialect/mysql/parser/MySqlStatementParser.java b/src/main/java/com/alibaba/druid/sql/dialect/mysql/parser/MySqlStatementParser.java index be7d736c70..6a76e7f088 100644 --- a/src/main/java/com/alibaba/druid/sql/dialect/mysql/parser/MySqlStatementParser.java +++ b/src/main/java/com/alibaba/druid/sql/dialect/mysql/parser/MySqlStatementParser.java @@ -2290,7 +2290,11 @@ public class MySqlStatementParser extends SQLStatementParser { SQLAlterTableAddConstraint item = new SQLAlterTableAddConstraint(primaryKey); stmt.getItems().add(item); } else if (lexer.token() == Token.KEY) { - throw new ParserException("TODO " + lexer.token() + " " + lexer.stringVal()); + // throw new ParserException("TODO " + lexer.token() + + // " " + lexer.stringVal()); + SQLAlterTableAddIndex item = parseAlterTableAddIndex(); + item.setParent(stmt); + stmt.getItems().add(item); } else if (lexer.token() == Token.CONSTRAINT) { lexer.nextToken(); SQLName constraintName = this.exprParser.name(); diff --git a/src/main/java/com/alibaba/druid/sql/parser/SQLStatementParser.java b/src/main/java/com/alibaba/druid/sql/parser/SQLStatementParser.java index 2c3841403d..7c3cf72a8f 100644 --- a/src/main/java/com/alibaba/druid/sql/parser/SQLStatementParser.java +++ b/src/main/java/com/alibaba/druid/sql/parser/SQLStatementParser.java @@ -1688,10 +1688,20 @@ public class SQLStatementParser extends SQLParser { item.setUnique(true); lexer.nextToken(); if (lexer.token() == Token.INDEX) { + item.setKeyOrIndex(Token.INDEX.name); + lexer.nextToken(); + } else if (lexer.token() == Token.KEY) { + item.setKeyOrIndex(Token.KEY.name); lexer.nextToken(); } } else { - accept(Token.INDEX); + if (lexer.token() == Token.INDEX) { + item.setKeyOrIndex(Token.INDEX.name); + accept(Token.INDEX); + } else if (lexer.token() == Token.KEY) { + item.setKeyOrIndex(Token.KEY.name); + accept(Token.KEY); + } } if (lexer.token() == Token.LPAREN) { diff --git a/src/main/java/com/alibaba/druid/sql/visitor/SQLASTOutputVisitor.java b/src/main/java/com/alibaba/druid/sql/visitor/SQLASTOutputVisitor.java index 90b935793c..1cb83ac538 100644 --- a/src/main/java/com/alibaba/druid/sql/visitor/SQLASTOutputVisitor.java +++ b/src/main/java/com/alibaba/druid/sql/visitor/SQLASTOutputVisitor.java @@ -1990,7 +1990,8 @@ public class SQLASTOutputVisitor extends SQLASTVisitorAdapter implements Printab print("UNIQUE "); } - print("INDEX "); + print(x.getKeyOrIndex()); + print(" "); if (x.getName() != null) { x.getName().accept(this); diff --git a/src/test/java/com/alibaba/druid/bvt/sql/mysql/MySqlAlterTableTest19.java b/src/test/java/com/alibaba/druid/bvt/sql/mysql/MySqlAlterTableTest19.java new file mode 100644 index 0000000000..c8f12ddb57 --- /dev/null +++ b/src/test/java/com/alibaba/druid/bvt/sql/mysql/MySqlAlterTableTest19.java @@ -0,0 +1,46 @@ +/* + * Copyright 1999-2011 Alibaba Group Holding Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.alibaba.druid.bvt.sql.mysql; + +import junit.framework.TestCase; + +import org.junit.Assert; + +import com.alibaba.druid.sql.SQLUtils; +import com.alibaba.druid.sql.ast.SQLStatement; +import com.alibaba.druid.sql.dialect.mysql.parser.MySqlStatementParser; +import com.alibaba.druid.sql.parser.Token; + +public class MySqlAlterTableTest19 extends TestCase { + + public void test_alter_add_key() throws Exception { + String sql = "ALTER TABLE `test`.`tb1` ADD KEY `idx_parent_id` (`parent_id`)"; + MySqlStatementParser parser = new MySqlStatementParser(sql); + SQLStatement stmt = parser.parseStatementList().get(0); + parser.match(Token.EOF); + String output = SQLUtils.toMySqlString(stmt); + Assert.assertEquals("ALTER TABLE `test`.`tb1`\n\tADD KEY `idx_parent_id` (`parent_id`)", output); + } + + public void test_alter_add_index() throws Exception { + String sql = "ALTER TABLE `test`.`tb1` ADD INDEX `idx_parent_id` (`parent_id`)"; + MySqlStatementParser parser = new MySqlStatementParser(sql); + SQLStatement stmt = parser.parseStatementList().get(0); + parser.match(Token.EOF); + String output = SQLUtils.toMySqlString(stmt); + Assert.assertEquals("ALTER TABLE `test`.`tb1`\n\tADD INDEX `idx_parent_id` (`parent_id`)", output); + } +}