From 1e62d8961e1da4c3303e5c39bdab9725f41133fc Mon Sep 17 00:00:00 2001 From: wenshao Date: Fri, 20 Apr 2018 11:00:25 +0800 Subject: [PATCH] refactor. --- .../com/alibaba/druid/stat/JdbcSqlStat.java | 39 ++++++++----------- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/src/main/java/com/alibaba/druid/stat/JdbcSqlStat.java b/src/main/java/com/alibaba/druid/stat/JdbcSqlStat.java index e7fbc42b44..5c6664c791 100644 --- a/src/main/java/com/alibaba/druid/stat/JdbcSqlStat.java +++ b/src/main/java/com/alibaba/druid/stat/JdbcSqlStat.java @@ -657,13 +657,11 @@ public final class JdbcSqlStat implements JdbcSqlStatMBean, Comparable= batchSize) { + break; + } + + if (executeBatchSizeMaxUpdater.compareAndSet(this, current, (int) batchSize)) { break; } } @@ -682,13 +680,11 @@ public final class JdbcSqlStat implements JdbcSqlStatMBean, Comparable max) { - if (concurrentMaxUpdater.compareAndSet(this, max, val)) { - break; - } else { - continue; - } - } else { + if (val <= max) { + break; + } + + if (concurrentMaxUpdater.compareAndSet(this, max, val)) { break; } } @@ -763,16 +759,13 @@ public final class JdbcSqlStat implements JdbcSqlStatMBean, Comparable= nanoSpan) { + break; + } - break; - } else { - continue; - } - } else { + if (executeSpanNanoMaxUpdater.compareAndSet(this, current, nanoSpan)) { + // 可能不准确,但是绝大多数情况下都会正确,性能换取一致性 + executeNanoSpanMaxOccurTime = System.currentTimeMillis(); break; } }