From 40b13a3eb38cd436aa39a2d47ea19eaa56f38e38 Mon Sep 17 00:00:00 2001 From: "shaojin.wensj" Date: Wed, 5 Oct 2022 22:07:40 +0800 Subject: [PATCH] fix testcase --- .../com/alibaba/druid/pool/DruidDataSource.java | 14 ++++++++++++-- .../OracleExceptionSorterTest_setReadOnly.java | 8 +++++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/com/alibaba/druid/pool/DruidDataSource.java b/core/src/main/java/com/alibaba/druid/pool/DruidDataSource.java index 6594e343ed..cc320c42e2 100644 --- a/core/src/main/java/com/alibaba/druid/pool/DruidDataSource.java +++ b/core/src/main/java/com/alibaba/druid/pool/DruidDataSource.java @@ -2332,11 +2332,21 @@ public class DruidDataSource extends DruidAbstractDataSource implements DruidDat } public long getCreateCount() { - return createCount; + lock.lock(); + try { + return createCount; + } finally { + lock.unlock(); + } } public long getDestroyCount() { - return destroyCount; + lock.lock(); + try { + return destroyCount; + } finally { + lock.unlock(); + } } public long getConnectCount() { diff --git a/core/src/test/java/com/alibaba/druid/bvt/pool/exception/OracleExceptionSorterTest_setReadOnly.java b/core/src/test/java/com/alibaba/druid/bvt/pool/exception/OracleExceptionSorterTest_setReadOnly.java index a2230a0b27..e6819ec498 100644 --- a/core/src/test/java/com/alibaba/druid/bvt/pool/exception/OracleExceptionSorterTest_setReadOnly.java +++ b/core/src/test/java/com/alibaba/druid/bvt/pool/exception/OracleExceptionSorterTest_setReadOnly.java @@ -28,6 +28,7 @@ public class OracleExceptionSorterTest_setReadOnly extends TestCase { dataSource.setDriver(new OracleMockDriver()); dataSource.setUrl("jdbc:mock:xxx"); + dataSource.setFilters("slf4j"); dataSource.setPoolPreparedStatements(true); dataSource.setMaxOpenPreparedStatements(100); } @@ -73,9 +74,10 @@ public class OracleExceptionSorterTest_setReadOnly extends TestCase { Connection conn2 = dataSource.getConnection(); conn2.close(); } - Assert.assertEquals(0, dataSource.getActiveCount()); - Assert.assertEquals(1, dataSource.getPoolingCount()); - Assert.assertEquals(2, dataSource.getCreateCount()); + assertEquals(1, dataSource.getDiscardCount()); + assertEquals(0, dataSource.getActiveCount()); + assertTrue(dataSource.getPoolingCount() >= 1); + assertTrue(dataSource.getCreateCount() >= 2); } }