improve WallFilter

src/test/java/com/alibaba/druid/bvt/filter/wall/MySqlWallTest8.java

@@ -0,0 +1,52 @@
+/*
+ * Copyright 1999-2011 Alibaba Group Holding Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.alibaba.druid.bvt.filter.wall;
+
+import junit.framework.TestCase;
+
+import org.junit.Assert;
+
+import com.alibaba.druid.wall.WallUtils;
+
+/**
+ * SQLServerWallTest
+ * 
+ * @author RaymondXiu
+ * @version 1.0, 2012-3-18
+ * @see
+ */
+public class MySqlWallTest8 extends TestCase {
+
+    public void test_false() throws Exception {
+        Assert.assertFalse(WallUtils.isValidateMySql(//
+        "SELECT a.* FROM vote_info a where 1=1 AND FID = ?")); // 前置永真
+    }
+    
+    public void test_false_1() throws Exception {
+        Assert.assertFalse(WallUtils.isValidateMySql(//
+        "SELECT a.* FROM vote_info a where FID = ? AND 1=1")); // 后置永真，拦截
+    }
+    
+    public void test_false_2() throws Exception {
+        Assert.assertFalse(WallUtils.isValidateMySql(//
+        "SELECT a.* FROM vote_info a where FID = ? OR (FID = ? AND 1=1)")); // 后置永真，拦截
+    }
+    
+    public void test_false_3() throws Exception {
+        Assert.assertFalse(WallUtils.isValidateMySql(//
+        "SELECT a.* FROM vote_info a where FID = ? OR (1=1 AND FID = ?)")); // 后置永真，拦截
+    }
+}

src/test/java/com/alibaba/druid/bvt/filter/wall/WallSelectWhereTest2.java

@@ -30,10 +30,10 @@ public class WallSelectWhereTest2 extends TestCase {
     private String sql = "SELECT F1, F2 WHERE 1 = 1 AND FID = ?";
 
     public void testMySql() throws Exception {
-        Assert.assertTrue(WallUtils.isValidateMySql(sql));
+        Assert.assertFalse(WallUtils.isValidateMySql(sql));
     }
     
     public void testORACLE() throws Exception {
-        Assert.assertTrue(WallUtils.isValidateOracle(sql));
+        Assert.assertFalse(WallUtils.isValidateOracle(sql));
     }
 }

src/test/java/com/alibaba/druid/bvt/filter/wall/WallSelectWhereTest3.java

@@ -22,7 +22,6 @@ import org.junit.Assert;
 import com.alibaba.druid.wall.WallUtils;
 
 /**
- * 这个场景，检测可疑的Having条件
  * @author wenshao
  *
  */
@@ -30,10 +29,10 @@ public class WallSelectWhereTest3 extends TestCase {
     private String sql = "select * from t WHERE FID = 256 AND CHR(67)||CHR(65)||CHR(84) = 'CAT'";
 
     public void testMySql() throws Exception {
-        Assert.assertTrue(WallUtils.isValidateMySql(sql));
+        Assert.assertFalse(WallUtils.isValidateMySql(sql));
     }
     
     public void testORACLE() throws Exception {
-        Assert.assertTrue(WallUtils.isValidateOracle(sql));
+        Assert.assertFalse(WallUtils.isValidateOracle(sql));
     }
 }