From 883d1fde6d675b0e19c3f2243738d6f07354e7b3 Mon Sep 17 00:00:00 2001
From: huangtiande <htd0324@gmail.com>
Date: Thu, 25 Dec 2014 18:10:54 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BF=AE=E5=A4=8D=E5=8D=95=E8=A1=8C=E3=80=81?=
 =?UTF-8?q?=E5=A4=9A=E8=A1=8C=E6=B3=A8=E9=87=8A=E6=9C=AA=E6=AD=A3=E5=B8=B8?=
 =?UTF-8?q?=E7=BB=93=E5=B0=BE=E7=9A=84bug=E3=80=82?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

原代码Lexer.java的nextToken处理注释的for循环在注释未正常结尾的时候没有及时退出。

如select a.id,--single comment a.name，单行注释结尾符应该是\r\n或\n。同理，多行注释结尾应该是*/。
---
 .../com/alibaba/druid/sql/parser/Lexer.java   | 11 ++-
 .../bvt/sql/postgresql/PGCommentTest.java     | 80 +++++++++++++++++++
 2 files changed, 90 insertions(+), 1 deletion(-)
 create mode 100644 src/test/java/com/alibaba/druid/bvt/sql/postgresql/PGCommentTest.java

diff --git a/src/main/java/com/alibaba/druid/sql/parser/Lexer.java b/src/main/java/com/alibaba/druid/sql/parser/Lexer.java
index 400eff4ea1..a6ba9efb2c 100644
--- a/src/main/java/com/alibaba/druid/sql/parser/Lexer.java
+++ b/src/main/java/com/alibaba/druid/sql/parser/Lexer.java
@@ -770,7 +770,11 @@ public class Lexer {
                 scanChar();
                 break;
             }
-
+            
+			// multiline comment结束符错误
+			if (ch == EOI) {
+				throw new ParserException("unterminated /* comment.");
+			}
             scanChar();
             bufPos++;
         }
@@ -800,6 +804,11 @@ public class Lexer {
                 scanChar();
                 break;
             }
+            
+			// single line comment结束符错误
+			if (ch == EOI) {
+				throw new ParserException("syntax error at end of input.");
+			}
 
             scanChar();
             bufPos++;
diff --git a/src/test/java/com/alibaba/druid/bvt/sql/postgresql/PGCommentTest.java b/src/test/java/com/alibaba/druid/bvt/sql/postgresql/PGCommentTest.java
new file mode 100644
index 0000000000..fb0ed10401
--- /dev/null
+++ b/src/test/java/com/alibaba/druid/bvt/sql/postgresql/PGCommentTest.java
@@ -0,0 +1,80 @@
+/*
+ * Copyright 1999-2011 Alibaba Group Holding Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.alibaba.druid.bvt.sql.postgresql;
+
+import java.util.List;
+
+import org.junit.Assert;
+
+import com.alibaba.druid.sql.PGTest;
+import com.alibaba.druid.sql.ast.SQLStatement;
+import com.alibaba.druid.sql.dialect.postgresql.parser.PGSQLStatementParser;
+import com.alibaba.druid.sql.dialect.postgresql.visitor.PGSchemaStatVisitor;
+import com.alibaba.druid.sql.parser.ParserException;
+import com.alibaba.druid.stat.TableStat;
+
+public class PGCommentTest extends PGTest {
+	
+	public void test_0() {
+		String sql = "/*multiline comment test"
+				+ ".\r\n multiline comment test select * from a;";
+
+		PGSQLStatementParser parser;
+		try {
+			parser = new PGSQLStatementParser(sql);
+			parser.parseStatementList();
+		} catch (Exception e) {
+			assertTrue(e instanceof ParserException);
+		}
+	}
+	
+	public void test_1() {
+		String sql = "select a.id,--single line comment test a.name from a;";
+
+		PGSQLStatementParser parser;
+		try {
+			parser = new PGSQLStatementParser(sql);
+			parser.parseStatementList();
+		} catch (Exception e) {
+			assertTrue(e instanceof ParserException);
+		}
+	}
+
+    public void test_2() throws Exception {
+        String sql = "/*multiline comment test"
+        		+ ".\r\n multiline comment test*"
+        		+ "/select --single line comment test\r\na.id,"
+        		+ "/*multiline comment test*/"
+        		+ "a.name from a;";
+
+        PGSQLStatementParser parser = new PGSQLStatementParser(sql);
+        List<SQLStatement> statementList = parser.parseStatementList();
+        SQLStatement statemen = statementList.get(0);
+        print(statementList);
+
+        Assert.assertEquals(1, statementList.size());
+
+        PGSchemaStatVisitor visitor = new PGSchemaStatVisitor();
+        statemen.accept(visitor);
+
+        System.out.println("Tables : " + visitor.getTables());
+        System.out.println("fields : " + visitor.getColumns());
+        System.out.println("coditions : " + visitor.getConditions());
+
+        Assert.assertTrue(visitor.getTables().containsKey(new TableStat.Name("a")));
+
+    }
+}