From 94e8ce55ec6556ffdd432c6bea855348957b36ee Mon Sep 17 00:00:00 2001
From: wenshao <szujobs@hotmail.com>
Date: Tue, 7 Aug 2012 07:34:49 +0800
Subject: [PATCH] if config incorrect, log error

---
 .../com/alibaba/druid/pool/DruidDataSource.java   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/main/java/com/alibaba/druid/pool/DruidDataSource.java b/src/main/java/com/alibaba/druid/pool/DruidDataSource.java
index d83f8e8b9a..98bbc55c6b 100644
--- a/src/main/java/com/alibaba/druid/pool/DruidDataSource.java
+++ b/src/main/java/com/alibaba/druid/pool/DruidDataSource.java
@@ -274,6 +274,12 @@ public class DruidDataSource extends DruidAbstractDataSource implements DruidDat
             if (this.driverClass != null) {
                 this.driverClass = driverClass.trim();
             }
+            
+            if (isTestOnBorrow() || isTestOnReturn() || isTestWhileIdle()) {
+                if (this.getValidationQuery() == null || this.getValidationQuery().length() == 0) {
+                    LOG.error("validationQuery not set");
+                }
+            }
 
             if (this.jdbcUrl != null) {
                 this.jdbcUrl = this.jdbcUrl.trim();
@@ -281,6 +287,9 @@ public class DruidDataSource extends DruidAbstractDataSource implements DruidDat
                 if (jdbcUrl.startsWith(DruidDriver.DEFAULT_PREFIX)) {
                     DataSourceProxyConfig config = DruidDriver.parseConfig(jdbcUrl, null);
                     this.driverClass = config.getRawDriverClassName();
+                    
+                    LOG.error("error url : " + jdbcUrl + ", it should be : " + config.getRawUrl());
+                    
                     this.jdbcUrl = config.getRawUrl();
                     if (this.name == null) {
                         this.name = config.getName();
@@ -343,6 +352,12 @@ public class DruidDataSource extends DruidAbstractDataSource implements DruidDat
             } else if (realDriverClassName.equals("com.alibaba.druid.mock.MockDriver")) {
                 this.exceptionSorter = new MockExceptionSorter();
             }
+            
+            if (realDriverClassName.equals("com.mysql.jdbc.Driver")) {
+                if (this.isPoolPreparedStatements()) {
+                    LOG.error("mysql should not use 'PoolPreparedStatements'");
+                }
+            }
 
             dataSourceStat = new JdbcDataSourceStat(this.name, this.jdbcUrl, this.dbType);