bug fixed for StatFilter resultSet multi-close

This commit is contained in:
wenshao
2012-08-06 17:42:09 +08:00
parent e879878863
commit a16b0a8412
4 changed files with 77 additions and 3 deletions
@@ -63,6 +63,7 @@ public class StatFilter extends FilterEventAdapter implements StatFilterMBean {
public final static String ATTR_UPDATE_COUNT = "stat.updteCount";
public final static String ATTR_TRANSACTION = "stat.tx";
public final static String ATTR_RESULTSET_CLOSED = "stat.rs.closed";
protected JdbcDataSourceStat dataSourceStat;
@@ -551,7 +552,7 @@ public class StatFilter extends FilterEventAdapter implements StatFilterMBean {
String sql = resultSet.getSql();
if (sql != null) {
JdbcSqlStat sqlStat = resultSet.getSqlStat();
if (sqlStat != null) {
if (sqlStat != null && resultSet.getCloseCount() == 0) {
sqlStat.addFetchRowCount(fetchCount);
long stmtExecuteNano = resultSet.getStatementProxy().getLastExecuteTimeNano();
sqlStat.addResultSetHoldTimeNano(stmtExecuteNano, nanoSpan);
@@ -772,7 +773,7 @@ public class StatFilter extends FilterEventAdapter implements StatFilterMBean {
chain.dataSource_recycle(conn);
long nanos = System.nanoTime() - conn.getConnectedTimeNano();
long millis = nanos / (1000L * 1000L);
dataSourceStat.getConnectionHoldHistogram().record(millis);
}
@@ -784,7 +785,7 @@ public class StatFilter extends FilterEventAdapter implements StatFilterMBean {
if (conn != null) {
conn.setConnectedTimeNano(System.nanoTime());
}
return conn;
}
@@ -41,4 +41,6 @@ public interface ResultSetProxy extends ResultSet, WrapperProxy {
void setConstructNano(long constructNano);
void setConstructNano();
int getCloseCount();
}
@@ -55,6 +55,7 @@ public class ResultSetProxyImpl extends WrapperProxyImpl implements ResultSetPro
protected int fetchRowCount = 0;
protected long constructNano;
protected final JdbcSqlStat sqlStat;
private int closeCount = 0;
public ResultSetProxyImpl(StatementProxy statement, ResultSet resultSet, long id, String sql){
super(resultSet, id);
@@ -134,6 +135,7 @@ public class ResultSetProxyImpl extends WrapperProxyImpl implements ResultSetPro
@Override
public void close() throws SQLException {
createChain().resultSet_close(this);
closeCount++;
}
@Override
@@ -1071,4 +1073,9 @@ public class ResultSetProxyImpl extends WrapperProxyImpl implements ResultSetPro
return super.unwrap(iface);
}
public int getCloseCount() {
return closeCount;
}
}