From bbfbb34af8dc9e70a9557a0f4339e2011cfb534c Mon Sep 17 00:00:00 2001 From: WaylanPunch Date: Fri, 15 Nov 2019 23:47:09 +0800 Subject: [PATCH 1/5] Collection.addAll() --- .../java/com/alibaba/druid/sql/ast/statement/SQLSelect.java | 4 +--- .../alibaba/druid/sql/ast/statement/SQLSelectQueryBlock.java | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelect.java b/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelect.java index 690a715ca4..c0625dc2cd 100644 --- a/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelect.java +++ b/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelect.java @@ -247,9 +247,7 @@ public class SQLSelect extends SQLObjectImpl { } if (this.hints != null) { - for (SQLHint hint : this.hints) { - x.hints.add(hint); - } + x.hints.addAll(this.hints); } x.forBrowse = forBrowse; diff --git a/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelectQueryBlock.java b/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelectQueryBlock.java index 033df7524d..3a4cbbb9a2 100644 --- a/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelectQueryBlock.java +++ b/src/main/java/com/alibaba/druid/sql/ast/statement/SQLSelectQueryBlock.java @@ -166,9 +166,7 @@ public class SQLSelectQueryBlock extends SQLObjectImpl implements SQLSelectQuery SQLInListExpr inListItem = (SQLInListExpr) item; if (inListExpr.getExpr().equals(inListItem.getExpr())) { TreeSet set = new TreeSet(); - for (SQLExpr itemItem : inListItem.getTargetList()) { - set.add(itemItem); - } + set.addAll(inListItem.getTargetList()); List andList = new ArrayList(); for (SQLExpr exprItem : inListExpr.getTargetList()) { From e3e04cb41b72dadcd542a131370bd72536a2cdce Mon Sep 17 00:00:00 2001 From: WaylanPunch Date: Sun, 17 Nov 2019 14:59:45 +0800 Subject: [PATCH 2/5] add @Override annotation --- .../java/com/alibaba/druid/sql/builder/SQLSelectBuilder.java | 1 + .../alibaba/druid/sql/builder/impl/SQLDeleteBuilderImpl.java | 1 + .../alibaba/druid/sql/builder/impl/SQLSelectBuilderImpl.java | 2 ++ .../alibaba/druid/sql/builder/impl/SQLUpdateBuilderImpl.java | 2 ++ 4 files changed, 6 insertions(+) diff --git a/src/main/java/com/alibaba/druid/sql/builder/SQLSelectBuilder.java b/src/main/java/com/alibaba/druid/sql/builder/SQLSelectBuilder.java index 60057402b9..5d919b098f 100644 --- a/src/main/java/com/alibaba/druid/sql/builder/SQLSelectBuilder.java +++ b/src/main/java/com/alibaba/druid/sql/builder/SQLSelectBuilder.java @@ -47,5 +47,6 @@ public interface SQLSelectBuilder { SQLSelectBuilder whereOr(String sql); + @Override String toString(); } diff --git a/src/main/java/com/alibaba/druid/sql/builder/impl/SQLDeleteBuilderImpl.java b/src/main/java/com/alibaba/druid/sql/builder/impl/SQLDeleteBuilderImpl.java index fc9e7cfaa7..177900438c 100644 --- a/src/main/java/com/alibaba/druid/sql/builder/impl/SQLDeleteBuilderImpl.java +++ b/src/main/java/com/alibaba/druid/sql/builder/impl/SQLDeleteBuilderImpl.java @@ -138,6 +138,7 @@ public class SQLDeleteBuilderImpl implements SQLDeleteBuilder { return new SQLDeleteStatement(); } + @Override public String toString() { return SQLUtils.toSQLString(stmt, dbType); } diff --git a/src/main/java/com/alibaba/druid/sql/builder/impl/SQLSelectBuilderImpl.java b/src/main/java/com/alibaba/druid/sql/builder/impl/SQLSelectBuilderImpl.java index 3a49dc48f3..3f351f9391 100644 --- a/src/main/java/com/alibaba/druid/sql/builder/impl/SQLSelectBuilderImpl.java +++ b/src/main/java/com/alibaba/druid/sql/builder/impl/SQLSelectBuilderImpl.java @@ -80,6 +80,7 @@ public class SQLSelectBuilderImpl implements SQLSelectBuilder { return stmt; } + @Override public SQLSelectBuilderImpl select(String... columns) { SQLSelectQueryBlock queryBlock = getQueryBlock(); @@ -266,6 +267,7 @@ public class SQLSelectBuilderImpl implements SQLSelectBuilder { return new SQLSelectGroupByClause(); } + @Override public String toString() { return SQLUtils.toSQLString(stmt, dbType); } diff --git a/src/main/java/com/alibaba/druid/sql/builder/impl/SQLUpdateBuilderImpl.java b/src/main/java/com/alibaba/druid/sql/builder/impl/SQLUpdateBuilderImpl.java index 2e5632dd33..fee27849b0 100644 --- a/src/main/java/com/alibaba/druid/sql/builder/impl/SQLUpdateBuilderImpl.java +++ b/src/main/java/com/alibaba/druid/sql/builder/impl/SQLUpdateBuilderImpl.java @@ -118,6 +118,7 @@ public class SQLUpdateBuilderImpl extends SQLBuilderImpl implements SQLUpdateBui return this; } + @Override public SQLUpdateBuilderImpl set(String... items) { SQLUpdateStatement update = getSQLUpdateStatement(); for (String item : items) { @@ -177,6 +178,7 @@ public class SQLUpdateBuilderImpl extends SQLBuilderImpl implements SQLUpdateBui return new SQLUpdateStatement(); } + @Override public String toString() { return SQLUtils.toSQLString(stmt, dbType); } From 5cb935104a6d7cb7c9402edf4e3335b1cd2417ac Mon Sep 17 00:00:00 2001 From: desertsurge Date: Wed, 20 Nov 2019 14:59:14 +0800 Subject: [PATCH 3/5] Update datasource.html MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix: 解决多数据源只能显示其中一个的问题 --- .../resources/support/http/resources/datasource.html | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/resources/support/http/resources/datasource.html b/src/main/resources/support/http/resources/datasource.html index 5ba6003460..38f17c70ce 100644 --- a/src/main/resources/support/http/resources/datasource.html +++ b/src/main/resources/support/http/resources/datasource.html @@ -25,14 +25,16 @@