fix sonar rule check violations

This commit is contained in:
wenshao
2012-08-29 17:18:17 +08:00
parent c07d671534
commit f3d2a88c4d
29 changed files with 110 additions and 135 deletions
@@ -32,7 +32,7 @@ import com.alibaba.druid.sql.parser.Token;
public class MySqlCreateTableParser extends SQLCreateTableParser {
public MySqlCreateTableParser(String sql) throws ParserException{
public MySqlCreateTableParser(String sql) {
super(new MySqlExprParser(sql));
}
@@ -40,11 +40,11 @@ public class MySqlCreateTableParser extends SQLCreateTableParser {
super(exprParser);
}
public SQLCreateTableStatement parseCrateTable() throws ParserException {
public SQLCreateTableStatement parseCrateTable() {
return parseCrateTable(true);
}
public MySqlCreateTableStatement parseCrateTable(boolean acceptCreate) throws ParserException {
public MySqlCreateTableStatement parseCrateTable(boolean acceptCreate) {
if (acceptCreate) {
accept(Token.CREATE);
}
@@ -182,7 +182,7 @@ public class MySqlCreateTableParser extends SQLCreateTableParser {
}
@SuppressWarnings("unused")
protected SQLTableConstaint parseConstraint() throws ParserException {
protected SQLTableConstaint parseConstraint() {
SQLName name = null;
if (lexer.token() == (Token.CONSTRAINT)) {
lexer.nextToken();
@@ -52,12 +52,12 @@ public class MySqlExprParser extends SQLExprParser {
super(lexer);
}
public MySqlExprParser(String sql) throws ParserException{
public MySqlExprParser(String sql) {
this(new MySqlLexer(sql));
this.lexer.nextToken();
}
public SQLExpr relationalRest(SQLExpr expr) throws ParserException {
public SQLExpr relationalRest(SQLExpr expr) {
if (identifierEquals("REGEXP")) {
lexer.nextToken();
SQLExpr rightExp = equality();
@@ -79,7 +79,7 @@ public class MySqlExprParser extends SQLExprParser {
return super.relationalRest(expr);
}
public SQLExpr multiplicativeRest(SQLExpr expr) throws ParserException {
public SQLExpr multiplicativeRest(SQLExpr expr) {
if (lexer.token() == Token.IDENTIFIER && "MOD".equalsIgnoreCase(lexer.stringVal())) {
lexer.nextToken();
SQLExpr rightExp = primary();
@@ -114,7 +114,7 @@ public class MySqlExprParser extends SQLExprParser {
return super.notRationalRest(expr);
}
public SQLExpr primary() throws ParserException {
public SQLExpr primary() {
final Token tok = lexer.token();
if (identifierEquals("outfile")) {
@@ -158,7 +158,7 @@ public class MySqlExprParser extends SQLExprParser {
}
public final SQLExpr primaryRest(SQLExpr expr) throws ParserException {
public final SQLExpr primaryRest(SQLExpr expr) {
if (expr == null) {
throw new IllegalArgumentException("expr");
}
@@ -489,7 +489,7 @@ public class MySqlExprParser extends SQLExprParser {
}
}
public SQLColumnDefinition parseColumn() throws ParserException {
public SQLColumnDefinition parseColumn() {
MySqlSQLColumnDefinition column = new MySqlSQLColumnDefinition();
column.setName(name());
column.setDataType(parseDataType());
@@ -497,7 +497,7 @@ public class MySqlExprParser extends SQLExprParser {
return parseColumnRest(column);
}
public SQLColumnDefinition parseColumnRest(SQLColumnDefinition column) throws ParserException {
public SQLColumnDefinition parseColumnRest(SQLColumnDefinition column) {
if (identifierEquals("AUTO_INCREMENT")) {
lexer.nextToken();
if (column instanceof MySqlSQLColumnDefinition) {
@@ -514,7 +514,7 @@ public class MySqlExprParser extends SQLExprParser {
return column;
}
public SQLExpr orRest(SQLExpr expr) throws ParserException {
public SQLExpr orRest(SQLExpr expr) {
for (;;) {
if (lexer.token() == Token.OR || lexer.token() == Token.BARBAR) {
@@ -566,7 +566,7 @@ public class MySqlExprParser extends SQLExprParser {
return item;
}
public SQLName nameRest(SQLName name) throws ParserException {
public SQLName nameRest(SQLName name) {
if (lexer.token() == Token.VARIANT && "@".equals(lexer.stringVal())) {
lexer.nextToken();
MySqlUserName userName = new MySqlUserName();
@@ -44,12 +44,12 @@ public class MySqlSelectParser extends SQLSelectParser {
super(exprParser);
}
public MySqlSelectParser(String sql) throws ParserException{
public MySqlSelectParser(String sql) {
this(new MySqlExprParser(sql));
}
@Override
public SQLSelectQuery query() throws ParserException {
public SQLSelectQuery query() {
if (lexer.token() == (Token.LPAREN)) {
lexer.nextToken();
@@ -220,7 +220,7 @@ public class MySqlSelectParser extends SQLSelectParser {
return queryRest(queryBlock);
}
protected void parseGroupBy(SQLSelectQueryBlock queryBlock) throws ParserException {
protected void parseGroupBy(SQLSelectQueryBlock queryBlock) {
if (lexer.token() == (Token.GROUP)) {
lexer.nextToken();
accept(Token.BY);
@@ -255,7 +255,7 @@ public class MySqlSelectParser extends SQLSelectParser {
}
}
protected SQLTableSource parseTableSourceRest(SQLTableSource tableSource) throws ParserException {
protected SQLTableSource parseTableSourceRest(SQLTableSource tableSource) {
if (identifierEquals("USING")) {
return tableSource;
}
@@ -144,7 +144,7 @@ public class MySqlStatementParser extends SQLStatementParser {
private static final String DELAYED = "DELAYED";
private static final String LOW_PRIORITY = "LOW_PRIORITY";
public MySqlStatementParser(String sql) throws ParserException{
public MySqlStatementParser(String sql) {
super(new MySqlExprParser(sql));
}