From fbbee2c651c6bfa740e3b3510378b31dd2f677af Mon Sep 17 00:00:00 2001 From: wenshao Date: Wed, 29 Aug 2012 15:52:17 +0800 Subject: [PATCH] Use String.indexOf(char) when checking for the index of a single character; it executes faster. --- .../java/com/alibaba/druid/support/http/util/IPAddress.java | 2 +- src/main/java/com/alibaba/druid/support/http/util/IPRange.java | 2 +- src/main/java/com/alibaba/druid/util/MapComparator.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/alibaba/druid/support/http/util/IPAddress.java b/src/main/java/com/alibaba/druid/support/http/util/IPAddress.java index 72791ccc01..cc7aee597f 100644 --- a/src/main/java/com/alibaba/druid/support/http/util/IPAddress.java +++ b/src/main/java/com/alibaba/druid/support/http/util/IPAddress.java @@ -227,7 +227,7 @@ public class IPAddress implements Cloneable { for (int i = 0; i < 3; i++) { // get the position of the first dot - int index = tmp.indexOf("."); + int index = tmp.indexOf('.'); // if there is not a dot then the ip string representation is // not compliant to the decimal-dotted notation. diff --git a/src/main/java/com/alibaba/druid/support/http/util/IPRange.java b/src/main/java/com/alibaba/druid/support/http/util/IPRange.java index b2e21a0c90..65f8c645f2 100644 --- a/src/main/java/com/alibaba/druid/support/http/util/IPRange.java +++ b/src/main/java/com/alibaba/druid/support/http/util/IPRange.java @@ -198,7 +198,7 @@ public class IPRange { throw new IllegalArgumentException("Invalid IP range"); } - int index = range.indexOf("/"); + int index = range.indexOf('/'); String subnetStr = null; if (index == -1) { ipAddress = new IPAddress(range); diff --git a/src/main/java/com/alibaba/druid/util/MapComparator.java b/src/main/java/com/alibaba/druid/util/MapComparator.java index 6afd71ba43..5438e72bfa 100644 --- a/src/main/java/com/alibaba/druid/util/MapComparator.java +++ b/src/main/java/com/alibaba/druid/util/MapComparator.java @@ -62,7 +62,7 @@ public class MapComparator implements Compar String keyStr = (String) key; if (keyStr.matches(".+\\[[0-9]+\\]")) { - Object value = map.get(keyStr.substring(0, keyStr.indexOf("["))); + Object value = map.get(keyStr.substring(0, keyStr.indexOf('['))); if (value == null) { return null; }