From b1e95babaa9da0e29789cce85de6a65f21285b5a Mon Sep 17 00:00:00 2001 From: Timothy Qiu Date: Tue, 1 Aug 2017 19:39:46 +0800 Subject: [PATCH] Fixes possible crash if url is malicious Try scan a QR code with content `ss://sdf invalid`, an uncaught exception raises. --- ShadowsocksX-NG/Utils.m | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ShadowsocksX-NG/Utils.m b/ShadowsocksX-NG/Utils.m index c77a07a..92912c9 100644 --- a/ShadowsocksX-NG/Utils.m +++ b/ShadowsocksX-NG/Utils.m @@ -56,7 +56,10 @@ void ScanQRCodeOnScreen() { NSLog(@"%@", feature.messageString); if ( [feature.messageString hasPrefix:@"ss://"] ) { - [foundSSUrls addObject:[NSURL URLWithString:feature.messageString]]; + NSURL *url = [NSURL URLWithString:feature.messageString]; + if (url) { + [foundSSUrls addObject:url]; + } } } CGImageRelease(image);