From a01be54971a72774d99f4f2f138c6def2153ff9b Mon Sep 17 00:00:00 2001 From: Qiu Yuzhou Date: Sun, 25 Oct 2026 23:15:40 +0800 Subject: [PATCH] fix: preserve weak release check without mutable local --- .../SubscriptionAutoUpdateWorkflowTests+Lifecycle.swift | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ShadowsocksX-NG2/Tests/Subscription/SubscriptionAutoUpdateWorkflowTests+Lifecycle.swift b/ShadowsocksX-NG2/Tests/Subscription/SubscriptionAutoUpdateWorkflowTests+Lifecycle.swift index 3b390066..94330f8e 100644 --- a/ShadowsocksX-NG2/Tests/Subscription/SubscriptionAutoUpdateWorkflowTests+Lifecycle.swift +++ b/ShadowsocksX-NG2/Tests/Subscription/SubscriptionAutoUpdateWorkflowTests+Lifecycle.swift @@ -95,7 +95,7 @@ extension SubscriptionAutoUpdateWorkflowTests { clockReads += 1 return fixture.now }) - weak var releasedWorkflow = workflow + let workflowIsReleased = { [weak workflow] in workflow == nil } defer { workflow?.stopSubscriptionAutomaticUpdates() fetcher.releaseAll() @@ -106,9 +106,8 @@ extension SubscriptionAutoUpdateWorkflowTests { workflow?.stopSubscriptionAutomaticUpdates() workflow = nil fetcher.releaseAll() - try await requireTestCondition("stopped batch released its workflow") { - releasedWorkflow == nil - } + try await requireTestCondition( + "stopped batch released its workflow", condition: workflowIsReleased) #expect(clockReads == readsBeforeStop) } }