Files
ShadowsocksX-NG/ShadowsocksX-NG2/Tests/Activation/ActivationStateFileStoreTests.swift
T
Qiu Yuzhou 20a62117f2 refactor(tests): 按功能领域重组 Tests/ 目录
Tests/ 根层原有 138 个平铺测试文件,无法从目录读出测试覆盖的功能领域。

按功能领域重组为 17 个目录(Catalog/Workflow 与 Rules/Custom 两处嵌套,分别
对应 App/Application/CatalogWorkflow 与 Domain/Rules/Custom):Architecture /
Support / Agent / Activation / Catalog / Subscription / Rules / ProxyRuntime /
ProxyControl / Runtime / Settings / SystemProxy / Plugin / Diagnostics /
Credentials / Workspace / Servers;Smoke/ 保持独立 target 不动。138 个移动中
132 个是 100% 相似度的纯重命名,其余 6 个在重命名之上带路径反推改写(见下)。

本次不是纯搬移:测试代码比生产代码多一层位置耦合,有 7 处用固定层数的
deletingLastPathComponent() 从 #filePath 反推仓库路径(都假定文件就在 Tests/
根层)。这 7 处改走新增的 Tests/Support/TestSourceTree.swift——从调用点沿父
目录上溯找到含 project.yml 的目录,因此不再依赖父目录层数,以后移动测试文件
也不会静默指错。

配套改动:

- 新增 Tests 布局守卫 TestsLayoutTests,断言 Tests/ 根层无平铺 .swift。比
  Domain 那条弱一档——根层的 Info.plist(info.path 生成物)与
  Fixtures/RuleSnapshots 下的 JSON(folder resource)都必须保留,不能用
  「树下只有 .swift」覆盖。
- project.yml:Smoke target 按文件引用的 Tests/AppArtifact.swift 改指
  Tests/Support/;两处注释里写死的 Tests/SkeletonTests.swift 随移动更新。
  excludes 的裸名 "Smoke" / "Fixtures" 仍匹配 Tests/ 直属子目录,无需改动。
- README 的 Tests 条目展开为目录说明,并修掉 Domain 条目里写死的
  Tests/SkeletonTests.swift。
- 顺带删去 DomainLayoutTests 文档注释里「整理前 62 个文件」这类易漂移的数字。

验证:xcodegen generate 后单测 target 为 139 个源文件(全部非 Smoke 文件,0 个
Smoke 文件混入)且仍以 Fixtures/RuleSnapshots 为资源,Smoke target 为 8 个
Smoke 文件加 AppArtifact;依赖路径反推的 6 个测试类全绿(路径指错即失败);
task format 未改写任何被移动文件;task lint 与整理前同为 21 条内容型 warning;
build 0 error;task test 1025 用例全通过(整理前 1024,+1 为新守卫);
TestsLayoutTests 经变异验证(根层投放探针即失败);packaging-gate ALL CHECKS
PASSED。
2026-10-05 20:37:35 +08:00

105 lines
4.1 KiB
Swift

import XCTest
@testable import ShadowsocksX_NG2
/// 活动目标持久化缝(票 #26):往返无损、缺失/损坏按安全侧恢复、权限基线。
final class ActivationStateFileStoreTests: XCTestCase {
private var workDir: URL!
private var store: ActivationStateFileStore!
override func setUpWithError() throws {
try super.setUpWithError()
workDir = FileManager.default.temporaryDirectory
.appendingPathComponent("activation-file-store-tests-\(UUID().uuidString)", isDirectory: true)
try FileManager.default.createDirectory(at: workDir, withIntermediateDirectories: true)
store = ActivationStateFileStore(fileURL: workDir.appendingPathComponent("activation.json"))
}
override func tearDownWithError() throws {
try FileManager.default.removeItem(at: workDir)
try super.tearDownWithError()
}
// MARK: 缺失与损坏
func testMissingFileLoadsAsNoActiveTarget() throws {
XCTAssertNil(try store.loadActiveTargetID(), "文件缺失按从未激活处理")
}
func testBrokenJSONLoadsAsNoActiveTargetOnTheSafeSide() throws {
try "{ not json {{{".write(to: store.fileURL, atomically: true, encoding: .utf8)
XCTAssertNil(
try store.loadActiveTargetID(), "损坏按安全侧恢复:无活动目标,代理保持停止")
}
func testUnknownSchemaVersionLoadsAsNoActiveTarget() throws {
let payload = """
{"version": 99, "activeTargetID": "s1"}
"""
try payload.write(to: store.fileURL, atomically: true, encoding: .utf8)
XCTAssertNil(try store.loadActiveTargetID())
}
// MARK: 往返无损
func testRoundTripPreservesTargetIdentity() throws {
let target = NodeID(rawValue: "manual:group-1")
try store.save(activeTargetID: target)
XCTAssertEqual(try store.loadActiveTargetID(), target, "目标身份跨持久化无损")
}
func testSavingNilClearsPersistedTarget() throws {
try store.save(activeTargetID: NodeID(rawValue: "s1"))
try store.save(activeTargetID: nil)
XCTAssertNil(try store.loadActiveTargetID(), "清除即整文件替换,不再残留旧目标")
}
// MARK: 权限基线
func testSaveCreatesDirectory0700AndFile0600() throws {
try store.save(activeTargetID: NodeID(rawValue: "s1"))
let fileAttributes = try FileManager.default.attributesOfItem(atPath: store.fileURL.path)
XCTAssertEqual(fileAttributes[.posixPermissions] as? Int, 0o600, "文件权限 0600")
let dirAttributes = try FileManager.default.attributesOfItem(atPath: workDir.path)
XCTAssertEqual(dirAttributes[.posixPermissions] as? Int, 0o700, "目录权限 0700")
}
func testDefaultFileURLMatchesRuntimeDirectoryContract() {
XCTAssertTrue(
ActivationStateFileStore.defaultFileURL().path.hasSuffix("ShadowsocksX-NG2/activation.json")
)
}
// MARK: 与状态机的生命周期往返
func testActivationLifecycleRoundTripThroughFileStore() throws {
var catalog = ConfigurationCatalog()
let credentials = InMemoryCredentialStore()
let leaf = try ActivationFixture.addPlainServer("a", in: &catalog, credentials: credentials)
var machine = ActivationStateMachine()
_ = try ActivationFixture.activate(&machine, leaf, in: catalog, credentials: credentials)
try store.save(activeTargetID: machine.activeTargetID)
// 下次启动:从文件恢复目标,载入目录后立即重校验(D5「重新校验同步」)。
var restored = ActivationStateMachine(activeTargetID: try store.loadActiveTargetID())
let configuration = try ActivationFixture.requireDeployed(
ActivationFixture.commit(&restored, catalog, credentials: credentials))
XCTAssertEqual(configuration.targetID, leaf, "恢复的目标重放派生")
// 目标随后失效:清除并停止,持久化同步清空。
try catalog.remove(leaf)
let failure = try ActivationFixture.requireCleared(
ActivationFixture.commit(&restored, catalog, credentials: credentials))
XCTAssertEqual(failure, .targetNotFound(leaf))
try store.save(activeTargetID: restored.activeTargetID)
XCTAssertNil(try store.loadActiveTargetID(), "清除随持久化落盘,重启不再复活旧目标")
}
}