Files
ShadowsocksX-NG/ShadowsocksX-NG2/Tests/Rules/Custom/CustomRuleValidatorTests.swift
T
Qiu Yuzhou 20a62117f2 refactor(tests): 按功能领域重组 Tests/ 目录
Tests/ 根层原有 138 个平铺测试文件,无法从目录读出测试覆盖的功能领域。

按功能领域重组为 17 个目录(Catalog/Workflow 与 Rules/Custom 两处嵌套,分别
对应 App/Application/CatalogWorkflow 与 Domain/Rules/Custom):Architecture /
Support / Agent / Activation / Catalog / Subscription / Rules / ProxyRuntime /
ProxyControl / Runtime / Settings / SystemProxy / Plugin / Diagnostics /
Credentials / Workspace / Servers;Smoke/ 保持独立 target 不动。138 个移动中
132 个是 100% 相似度的纯重命名,其余 6 个在重命名之上带路径反推改写(见下)。

本次不是纯搬移:测试代码比生产代码多一层位置耦合,有 7 处用固定层数的
deletingLastPathComponent() 从 #filePath 反推仓库路径(都假定文件就在 Tests/
根层)。这 7 处改走新增的 Tests/Support/TestSourceTree.swift——从调用点沿父
目录上溯找到含 project.yml 的目录,因此不再依赖父目录层数,以后移动测试文件
也不会静默指错。

配套改动:

- 新增 Tests 布局守卫 TestsLayoutTests,断言 Tests/ 根层无平铺 .swift。比
  Domain 那条弱一档——根层的 Info.plist(info.path 生成物)与
  Fixtures/RuleSnapshots 下的 JSON(folder resource)都必须保留,不能用
  「树下只有 .swift」覆盖。
- project.yml:Smoke target 按文件引用的 Tests/AppArtifact.swift 改指
  Tests/Support/;两处注释里写死的 Tests/SkeletonTests.swift 随移动更新。
  excludes 的裸名 "Smoke" / "Fixtures" 仍匹配 Tests/ 直属子目录,无需改动。
- README 的 Tests 条目展开为目录说明,并修掉 Domain 条目里写死的
  Tests/SkeletonTests.swift。
- 顺带删去 DomainLayoutTests 文档注释里「整理前 62 个文件」这类易漂移的数字。

验证:xcodegen generate 后单测 target 为 139 个源文件(全部非 Smoke 文件,0 个
Smoke 文件混入)且仍以 Fixtures/RuleSnapshots 为资源,Smoke target 为 8 个
Smoke 文件加 AppArtifact;依赖路径反推的 6 个测试类全绿(路径指错即失败);
task format 未改写任何被移动文件;task lint 与整理前同为 21 条内容型 warning;
build 0 error;task test 1025 用例全通过(整理前 1024,+1 为新守卫);
TestsLayoutTests 经变异验证(根层投放探针即失败);packaging-gate ALL CHECKS
PASSED。
2026-10-05 20:37:35 +08:00

278 lines
10 KiB
Swift

import Foundation
import XCTest
@testable import ShadowsocksX_NG2
/// 自定义规则校验(issue #66 AC2):固定本地冲突、ACL 优先级说明与重复拒绝,
/// 并返回可解释原因。
final class CustomRuleValidatorTests: XCTestCase {
private func rule(
_ action: RuleAction,
_ match: RuleMatch,
id: UUID = UUID()
) -> CustomRule {
CustomRule(id: id, action: action, match: match)
}
func testOppositeActionsAreRetainedRegardlessOfCustomOrder() throws {
let rules = [
rule(.direct, try RuleMatch(domainExact: "a.example.com")),
rule(.proxy, try RuleMatch(domainSuffix: "example.com")),
]
let first = CustomRuleValidator.validate(custom: rules, defaultAction: .directWhenUnmatched)
let reversed = CustomRuleValidator.validate(
custom: Array(rules.reversed()), defaultAction: .directWhenUnmatched)
XCTAssertTrue(first.rejected.isEmpty)
XCTAssertTrue(reversed.rejected.isEmpty)
XCTAssertEqual(first, reversed)
XCTAssertEqual(first.accepted.count, 2)
}
// MARK: 有效规则
func testValidDomainAndCIDRRulesAreAccepted() throws {
let custom = [
rule(.proxy, try RuleMatch(domainSuffix: "blocked.example")),
rule(.direct, try RuleMatch(domainExact: "ok.example.cn")),
rule(.direct, try RuleMatch(ipv4CIDR: "203.0.113.0/24")),
rule(.proxy, try RuleMatch(ipv6CIDR: "2001:db8::/32")),
]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .directWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.accepted.count, 4)
XCTAssertTrue(
result.accepted.contains { $0.aclLine == "||blocked.example" && $0.action == .proxy })
}
func testMappedIPv6CannotBypassFixedLocalConflictValidation() throws {
let privateRule = rule(.proxy, try RuleMatch(ipv6CIDR: "::ffff:192.168.1.2"))
let broadRule = rule(.proxy, try RuleMatch(ipv6CIDR: "::ffff:0.0.0.0/96"))
let publicRule = rule(.proxy, try RuleMatch(ipv6CIDR: "::ffff:203.0.113.8"))
let result = CustomRuleValidator.validate(
custom: [privateRule, publicRule, broadRule], defaultAction: .directWhenUnmatched)
XCTAssertEqual(result.rejected.count, 2)
XCTAssertTrue(result.rejected.allSatisfy { $0.reason == .conflictsWithFixedLocalScope })
XCTAssertEqual(result.accepted, [publicRule.proxyRule])
}
// MARK: 固定本地冲突
func testProxyRuleOverFixedLocalIPRangeIsRejected() throws {
let custom = [rule(.proxy, try RuleMatch(ipv4CIDR: "10.1.2.3/32"))]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .directWhenUnmatched)
XCTAssertEqual(result.accepted.count, 0)
XCTAssertEqual(result.rejected.count, 1)
XCTAssertEqual(result.rejected[0].reason, .conflictsWithFixedLocalScope)
XCTAssertFalse(result.rejected[0].explanation.isEmpty)
}
func testProxyRuleOverlappingFixedLocalIPRangeIsRejected() throws {
// 172.0.0.0/8 与固定本地 172.16.0.0/12 相交。
let custom = [rule(.proxy, try RuleMatch(ipv4CIDR: "172.0.0.0/8"))]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .proxyWhenUnmatched)
XCTAssertEqual(result.rejected.map(\.reason), [.conflictsWithFixedLocalScope])
}
func testProxyRuleOverLocalHostnameIsRejected() throws {
let custom = [
rule(.proxy, try RuleMatch(domainExact: "localhost")),
rule(.proxy, try RuleMatch(domainExact: "printer.local")),
rule(.proxy, try RuleMatch(domainExact: "myhost")),
rule(.proxy, try RuleMatch(domainSuffix: "home.local")),
]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .directWhenUnmatched)
XCTAssertEqual(result.accepted.count, 0)
XCTAssertEqual(result.rejected.count, 4)
XCTAssertTrue(
result.rejected.allSatisfy { $0.reason == .conflictsWithFixedLocalScope })
}
func testDirectRuleOverFixedLocalIsAllowed() throws {
let custom = [rule(.direct, try RuleMatch(ipv4CIDR: "127.0.0.0/8"))]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .proxyWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.accepted.count, 1)
}
func testProxyRuleOutsideFixedLocalIsAllowed() throws {
let custom = [
rule(.proxy, try RuleMatch(ipv4CIDR: "203.0.113.0/24")),
rule(.proxy, try RuleMatch(domainSuffix: "example.com")),
rule(.proxy, try RuleMatch(ipv4CIDR: "172.15.0.0/16")),
]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .directWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.accepted.count, 3)
}
// MARK: 遮蔽
func testDomainDirectShadowedByBroaderDomainProxyIsExplainedWhenProxySideWritten() throws {
let builtIn = [
ProxyRule(
action: .proxy, match: try RuleMatch(domainSuffix: "blocked.example"))
]
let custom = [rule(.direct, try RuleMatch(domainExact: "sub.blocked.example"))]
let result = CustomRuleValidator.validate(
custom: custom, builtIn: builtIn, defaultAction: .directWhenUnmatched)
XCTAssertEqual(result.accepted.count, 1)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.relationships.first?.extent, .full)
}
func testDomainDirectNotShadowedWhenProxySideNotWritten() throws {
// 「未匹配时代理」骨架不写 proxy_list,域名代理表为空,直连规则不会被遮蔽。
let builtIn = [
ProxyRule(
action: .proxy, match: try RuleMatch(domainSuffix: "blocked.example"))
]
let custom = [rule(.direct, try RuleMatch(domainExact: "sub.blocked.example"))]
let result = CustomRuleValidator.validate(
custom: custom, builtIn: builtIn, defaultAction: .proxyWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.accepted.count, 1)
}
func testIPProxyShadowedByBroaderIPDirectIsExplainedWhenProxySideWritten() throws {
let builtIn = [
ProxyRule(
action: .direct, match: try RuleMatch(ipv4CIDR: "203.0.113.0/24"))
]
let custom = [rule(.proxy, try RuleMatch(ipv4CIDR: "203.0.113.10/32"))]
let result = CustomRuleValidator.validate(
custom: custom, builtIn: builtIn, defaultAction: .directWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.relationships.first?.kind, .shadowing)
XCTAssertEqual(result.relationships.first?.extent, .full)
}
func testIPProxyNotRejectedWhenProxySideNotWritten() throws {
// 「未匹配时代理」不写 proxy_list;IP 代理规则不参与 bypass 优先判定。
let builtIn = [
ProxyRule(
action: .direct, match: try RuleMatch(ipv4CIDR: "203.0.113.0/24"))
]
let custom = [rule(.proxy, try RuleMatch(ipv4CIDR: "203.0.113.10/32"))]
let result = CustomRuleValidator.validate(
custom: custom, builtIn: builtIn, defaultAction: .proxyWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.accepted.count, 1)
}
func testDomainProxyNotShadowedByDomainDirect() throws {
// 域名 proxy_list 优先于 bypass_list:代理规则不会被直连遮蔽。
let builtIn = [
ProxyRule(
action: .direct, match: try RuleMatch(domainSuffix: "example.com"))
]
let custom = [rule(.proxy, try RuleMatch(domainExact: "a.example.com"))]
let result = CustomRuleValidator.validate(
custom: custom, builtIn: builtIn, defaultAction: .directWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
}
func testCustomToCustomDomainShadowingIsDetected() throws {
let custom = [
rule(.proxy, try RuleMatch(domainSuffix: "example.com")),
rule(.direct, try RuleMatch(domainExact: "a.example.com")),
]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .directWhenUnmatched)
XCTAssertEqual(result.accepted.count, 2)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.relationships.first?.rule.action, .direct)
}
func testCustomToCustomIPShadowingIsDetected() throws {
let custom = [
rule(.direct, try RuleMatch(ipv4CIDR: "198.51.100.0/24")),
rule(.proxy, try RuleMatch(ipv4CIDR: "198.51.100.5/32")),
]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .directWhenUnmatched)
XCTAssertTrue(result.rejected.isEmpty)
XCTAssertEqual(result.relationships.first?.kind, .shadowing)
XCTAssertEqual(result.relationships.first?.extent, .full)
XCTAssertEqual(result.relationships.first?.rule.action, .proxy)
}
// MARK: 重复
func testDuplicateContentIsRejected() throws {
let match = try RuleMatch(domainSuffix: "example.com")
let custom = [
rule(.proxy, match),
rule(.proxy, match),
]
let result = CustomRuleValidator.validate(
custom: custom, defaultAction: .directWhenUnmatched)
XCTAssertTrue(result.accepted.isEmpty)
XCTAssertEqual(result.rejected.map(\.reason), [.duplicate, .duplicate])
}
// MARK: 覆盖判定
func testDomainCoverageMatrix() throws {
let suffixExample = try RuleMatch(domainSuffix: "example.com")
let exactA = try RuleMatch(domainExact: "a.example.com")
let exactExample = try RuleMatch(domainExact: "example.com")
let suffixA = try RuleMatch(domainSuffix: "a.example.com")
let suffixOther = try RuleMatch(domainSuffix: "other.example")
XCTAssertTrue(RuleCoverage.domainCovers(suffixExample, exactA))
XCTAssertTrue(RuleCoverage.domainCovers(suffixExample, exactExample))
XCTAssertTrue(RuleCoverage.domainCovers(suffixExample, suffixA))
XCTAssertFalse(RuleCoverage.domainCovers(exactA, suffixA), "精确不覆盖后缀")
XCTAssertFalse(RuleCoverage.domainCovers(suffixA, suffixExample), "窄后缀不覆盖宽后缀")
XCTAssertFalse(RuleCoverage.domainCovers(suffixExample, suffixOther))
XCTAssertTrue(RuleCoverage.domainCovers(exactA, exactA))
}
func testIPCoverageMatrix() throws {
let slash8 = try RuleMatch(ipv4CIDR: "10.0.0.0/8")
let slash16 = try RuleMatch(ipv4CIDR: "10.1.0.0/16")
let host = try RuleMatch(ipv4CIDR: "10.1.2.3/32")
let other = try RuleMatch(ipv4CIDR: "11.0.0.0/8")
XCTAssertTrue(RuleCoverage.ipCovers(slash8, slash16))
XCTAssertTrue(RuleCoverage.ipCovers(slash8, host))
XCTAssertFalse(RuleCoverage.ipCovers(slash16, slash8))
XCTAssertFalse(RuleCoverage.ipCovers(slash8, other))
}
}