mirror of
https://github.com/shadowsocks/ShadowsocksX-NG.git
synced 2026-11-16 04:54:42 +00:00
Tests/ 根层原有 138 个平铺测试文件,无法从目录读出测试覆盖的功能领域。 按功能领域重组为 17 个目录(Catalog/Workflow 与 Rules/Custom 两处嵌套,分别 对应 App/Application/CatalogWorkflow 与 Domain/Rules/Custom):Architecture / Support / Agent / Activation / Catalog / Subscription / Rules / ProxyRuntime / ProxyControl / Runtime / Settings / SystemProxy / Plugin / Diagnostics / Credentials / Workspace / Servers;Smoke/ 保持独立 target 不动。138 个移动中 132 个是 100% 相似度的纯重命名,其余 6 个在重命名之上带路径反推改写(见下)。 本次不是纯搬移:测试代码比生产代码多一层位置耦合,有 7 处用固定层数的 deletingLastPathComponent() 从 #filePath 反推仓库路径(都假定文件就在 Tests/ 根层)。这 7 处改走新增的 Tests/Support/TestSourceTree.swift——从调用点沿父 目录上溯找到含 project.yml 的目录,因此不再依赖父目录层数,以后移动测试文件 也不会静默指错。 配套改动: - 新增 Tests 布局守卫 TestsLayoutTests,断言 Tests/ 根层无平铺 .swift。比 Domain 那条弱一档——根层的 Info.plist(info.path 生成物)与 Fixtures/RuleSnapshots 下的 JSON(folder resource)都必须保留,不能用 「树下只有 .swift」覆盖。 - project.yml:Smoke target 按文件引用的 Tests/AppArtifact.swift 改指 Tests/Support/;两处注释里写死的 Tests/SkeletonTests.swift 随移动更新。 excludes 的裸名 "Smoke" / "Fixtures" 仍匹配 Tests/ 直属子目录,无需改动。 - README 的 Tests 条目展开为目录说明,并修掉 Domain 条目里写死的 Tests/SkeletonTests.swift。 - 顺带删去 DomainLayoutTests 文档注释里「整理前 62 个文件」这类易漂移的数字。 验证:xcodegen generate 后单测 target 为 139 个源文件(全部非 Smoke 文件,0 个 Smoke 文件混入)且仍以 Fixtures/RuleSnapshots 为资源,Smoke target 为 8 个 Smoke 文件加 AppArtifact;依赖路径反推的 6 个测试类全绿(路径指错即失败); task format 未改写任何被移动文件;task lint 与整理前同为 21 条内容型 warning; build 0 error;task test 1025 用例全通过(整理前 1024,+1 为新守卫); TestsLayoutTests 经变异验证(根层投放探针即失败);packaging-gate ALL CHECKS PASSED。
136 lines
6.2 KiB
Swift
136 lines
6.2 KiB
Swift
import XCTest
|
|
|
|
@testable import ShadowsocksX_NG2
|
|
|
|
@MainActor
|
|
final class OfflineRulesWorkflowTests: XCTestCase {
|
|
func testAddressTestUsesCompleteSavedCollectionDespiteBrowsingFilters() async throws {
|
|
let rule = CustomRule(action: .proxy, match: try RuleMatch(domainSuffix: "example.com"))
|
|
let workflow = RulesWorkflow(
|
|
loadCustom: { [rule] }, builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
|
|
await workflow.refresh()
|
|
workflow.query(RulesQuery(search: "hidden", action: .direct, source: .chinaIPv4))
|
|
XCTAssertTrue(workflow.snapshot.rows.isEmpty)
|
|
workflow.setTestTarget("a.example.com")
|
|
await workflow.testAddress()
|
|
let result = try XCTUnwrap(workflow.snapshot.addressTest.result)
|
|
XCTAssertEqual(result.outcome, .proxy)
|
|
XCTAssertEqual(result.version, workflow.snapshot.version)
|
|
XCTAssertEqual(result.deciding.map(\.identity), [rule.identity])
|
|
XCTAssertTrue(result.domainWithoutDNS)
|
|
}
|
|
func testInvalidAndIncompleteCollectionsExposeOperationErrors() async throws {
|
|
let workflow = RulesWorkflow(
|
|
loadCustom: { [] }, builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
|
|
workflow.setTestTarget("example.com")
|
|
await workflow.testAddress()
|
|
XCTAssertEqual(workflow.snapshot.addressTest.failure, .incompleteCollection)
|
|
await workflow.refresh()
|
|
workflow.setTestTarget("https://")
|
|
await workflow.testAddress()
|
|
XCTAssertEqual(workflow.snapshot.addressTest.failure, .invalidTarget)
|
|
XCTAssertNil(workflow.snapshot.addressTest.result)
|
|
let incomplete = RulesWorkflow(
|
|
loadCustom: { [] },
|
|
builtinSnapshots: BuiltinRuleSnapshots(loader: { _ in throw RuleSnapshotError.missing }))
|
|
await incomplete.refresh()
|
|
incomplete.setTestTarget("localhost")
|
|
await incomplete.testAddress()
|
|
XCTAssertEqual(incomplete.snapshot.addressTest.failure, .incompleteCollection)
|
|
XCTAssertNil(incomplete.snapshot.addressTest.result)
|
|
}
|
|
|
|
func testPublicRefreshClearsOldResultAndUsesNewSavedVersion() async throws {
|
|
let directory = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
|
defer { try? FileManager.default.removeItem(at: directory) }
|
|
let store = CustomRuleStore(fileURL: directory.appendingPathComponent("rules.json"))
|
|
let proxy = CustomRule(action: .proxy, match: try RuleMatch(domainExact: "example.com"))
|
|
try store.save([proxy])
|
|
let workflow = RulesWorkflow(
|
|
loadCustom: { try store.load() },
|
|
builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
|
|
await workflow.refresh()
|
|
workflow.setTestTarget("example.com")
|
|
await workflow.testAddress()
|
|
let version = workflow.snapshot.addressTest.result?.version
|
|
try store.save([CustomRule(action: .direct, match: proxy.match)])
|
|
await workflow.refresh()
|
|
XCTAssertNil(workflow.snapshot.addressTest.result)
|
|
XCTAssertFalse(workflow.snapshot.addressTest.isTesting)
|
|
XCTAssertNotEqual(workflow.snapshot.version, version)
|
|
XCTAssertEqual(workflow.snapshot.addressTest.target, "example.com")
|
|
await workflow.testAddress()
|
|
XCTAssertEqual(workflow.snapshot.addressTest.result?.outcome, .direct)
|
|
try Data("broken".utf8).write(to: store.fileURL)
|
|
await workflow.refresh()
|
|
await workflow.testAddress()
|
|
XCTAssertEqual(workflow.snapshot.addressTest.failure, .incompleteCollection)
|
|
XCTAssertNil(workflow.snapshot.addressTest.result)
|
|
}
|
|
|
|
func testClearingTargetOrStartingRefreshPreventsLateTestPublication() async throws {
|
|
let rule = CustomRule(action: .proxy, match: try RuleMatch(domainSuffix: "example.com"))
|
|
let workflow = RulesWorkflow(
|
|
loadCustom: { [rule] }, builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
|
|
await workflow.refresh()
|
|
workflow.setTestTarget("example.com")
|
|
await workflow.testAddress()
|
|
workflow.setTestTarget("")
|
|
XCTAssertNil(workflow.snapshot.addressTest.result)
|
|
XCTAssertNil(workflow.snapshot.addressTest.failure)
|
|
|
|
// Queue a new public command as soon as the old test starts. The old
|
|
// detached task must not publish after that command invalidates its intent.
|
|
for refresh in [false, true] {
|
|
workflow.setTestTarget("example.com")
|
|
var invalidation: Task<Void, Never>?
|
|
let observation = workflow.$snapshot.sink { page in
|
|
guard page.addressTest.isTesting, invalidation == nil else { return }
|
|
invalidation = Task { @MainActor in
|
|
if refresh { await workflow.refresh() } else { workflow.setTestTarget("") }
|
|
}
|
|
}
|
|
await workflow.testAddress()
|
|
await invalidation?.value
|
|
observation.cancel()
|
|
XCTAssertNil(workflow.snapshot.addressTest.result)
|
|
XCTAssertFalse(workflow.snapshot.addressTest.isTesting)
|
|
}
|
|
}
|
|
|
|
func testExternalSettingsChangesNeverSupplyAFallbackOrAlterThreeStateResults() async throws {
|
|
let directory = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
|
defer { try? FileManager.default.removeItem(at: directory) }
|
|
let settings = ProxySettingsFileStore(
|
|
fileURL: directory.appendingPathComponent("settings.json"))
|
|
let rules = [
|
|
CustomRule(action: .proxy, match: try RuleMatch(domainExact: "proxy.example")),
|
|
CustomRule(action: .direct, match: try RuleMatch(domainExact: "direct.example")),
|
|
]
|
|
let workflow = RulesWorkflow(
|
|
loadCustom: { rules }, builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
|
|
await workflow.refresh()
|
|
for mode in [ProxyModeKind.rule, .global, .direct] {
|
|
for defaultAction in RuleDefaultAction.allCases {
|
|
for enabled in [false, true] {
|
|
try settings.save(
|
|
ProxySettings(
|
|
preferredMode: mode, ruleDefaultAction: defaultAction,
|
|
agentEnabled: enabled, systemProxyEnabled: enabled))
|
|
workflow.query(RulesQuery(search: "hidden", source: .fixed))
|
|
for (target, outcome) in [
|
|
("proxy.example", OfflineRuleMatcher.Outcome.proxy),
|
|
("direct.example", .direct), ("unresolved.example", .unmatched),
|
|
("198.51.100.8", .unmatched),
|
|
] {
|
|
workflow.setTestTarget(target)
|
|
await workflow.testAddress()
|
|
XCTAssertEqual(workflow.snapshot.addressTest.result?.outcome, outcome)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|