Files
ShadowsocksX-NG/ShadowsocksX-NG2/Tests/Rules/RulesWorkflowCoverageTests.swift
T
Qiu Yuzhou 20a62117f2 refactor(tests): 按功能领域重组 Tests/ 目录
Tests/ 根层原有 138 个平铺测试文件,无法从目录读出测试覆盖的功能领域。

按功能领域重组为 17 个目录(Catalog/Workflow 与 Rules/Custom 两处嵌套,分别
对应 App/Application/CatalogWorkflow 与 Domain/Rules/Custom):Architecture /
Support / Agent / Activation / Catalog / Subscription / Rules / ProxyRuntime /
ProxyControl / Runtime / Settings / SystemProxy / Plugin / Diagnostics /
Credentials / Workspace / Servers;Smoke/ 保持独立 target 不动。138 个移动中
132 个是 100% 相似度的纯重命名,其余 6 个在重命名之上带路径反推改写(见下)。

本次不是纯搬移:测试代码比生产代码多一层位置耦合,有 7 处用固定层数的
deletingLastPathComponent() 从 #filePath 反推仓库路径(都假定文件就在 Tests/
根层)。这 7 处改走新增的 Tests/Support/TestSourceTree.swift——从调用点沿父
目录上溯找到含 project.yml 的目录,因此不再依赖父目录层数,以后移动测试文件
也不会静默指错。

配套改动:

- 新增 Tests 布局守卫 TestsLayoutTests,断言 Tests/ 根层无平铺 .swift。比
  Domain 那条弱一档——根层的 Info.plist(info.path 生成物)与
  Fixtures/RuleSnapshots 下的 JSON(folder resource)都必须保留,不能用
  「树下只有 .swift」覆盖。
- project.yml:Smoke target 按文件引用的 Tests/AppArtifact.swift 改指
  Tests/Support/;两处注释里写死的 Tests/SkeletonTests.swift 随移动更新。
  excludes 的裸名 "Smoke" / "Fixtures" 仍匹配 Tests/ 直属子目录,无需改动。
- README 的 Tests 条目展开为目录说明,并修掉 Domain 条目里写死的
  Tests/SkeletonTests.swift。
- 顺带删去 DomainLayoutTests 文档注释里「整理前 62 个文件」这类易漂移的数字。

验证:xcodegen generate 后单测 target 为 139 个源文件(全部非 Smoke 文件,0 个
Smoke 文件混入)且仍以 Fixtures/RuleSnapshots 为资源,Smoke target 为 8 个
Smoke 文件加 AppArtifact;依赖路径反推的 6 个测试类全绿(路径指错即失败);
task format 未改写任何被移动文件;task lint 与整理前同为 21 条内容型 warning;
build 0 error;task test 1025 用例全通过(整理前 1024,+1 为新守卫);
TestsLayoutTests 经变异验证(根层投放探针即失败);packaging-gate ALL CHECKS
PASSED。
2026-10-05 20:37:35 +08:00

94 lines
4.9 KiB
Swift

import XCTest
@testable import ShadowsocksX_NG2
@MainActor
final class RulesWorkflowCoverageTests: XCTestCase {
func testCoverageUsesAllSourcesAndDistinguishesPartialFromFull() async throws {
let broad = CustomRule(action: .direct, match: try RuleMatch(domainSuffix: "example.com"))
let narrow = CustomRule(action: .proxy, match: try RuleMatch(domainExact: "www.example.com"))
let duplicate = CustomRule(
action: .direct, match: try RuleMatch(domainExact: "www.example.com"))
let workflow = RulesWorkflow(
loadCustom: { [broad, narrow, duplicate] },
builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
await workflow.refresh()
workflow.query(RulesQuery(action: .direct, source: .custom))
let broadRow = try XCTUnwrap(workflow.snapshot.rows.first { $0.identity == broad.identity })
XCTAssertTrue(
broadRow.relationships.contains {
$0.kind == .shadowing && $0.extent == .partial && $0.covering == [narrow.identity]
})
let narrowRow = try XCTUnwrap(
workflow.snapshot.rows.first { $0.identity == duplicate.identity })
XCTAssertTrue(narrowRow.relationships.contains { $0.kind == .shadowing && $0.extent == .full })
XCTAssertTrue(narrowRow.relationships.contains { $0.kind == .absorption && $0.extent == .full })
XCTAssertTrue(workflow.snapshot.rows.filter(\.isFixed).allSatisfy { $0.relationships.isEmpty })
}
func testMappedIPAndCombinedNarrowRangesExplainCoverageThroughWorkflow() async throws {
let proxy = CustomRule(action: .proxy, match: try RuleMatch(ipv6CIDR: "::ffff:8.8.8.0/120"))
let lower = CustomRule(action: .direct, match: try RuleMatch(ipv4CIDR: "8.8.8.0/25"))
let upper = CustomRule(action: .direct, match: try RuleMatch(ipv4CIDR: "8.8.8.128/25"))
let workflow = RulesWorkflow(
loadCustom: { [proxy, lower, upper] },
builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
await workflow.refresh()
workflow.query(RulesQuery(action: .proxy, source: .custom))
let row = try XCTUnwrap(workflow.snapshot.rows.first)
XCTAssertEqual(row.identity, proxy.identity)
XCTAssertEqual(row.relationships.count, 1)
XCTAssertEqual(row.relationships.first?.kind, .shadowing)
XCTAssertEqual(row.relationships.first?.extent, .full)
XCTAssertEqual(Set(row.relationships.first?.covering ?? []), [lower.identity, upper.identity])
}
func testFixedProtectionExplainsSimpleHostsAndPreventsFalseLocalShadowing() async throws {
let simple = ProxyRule(
action: .proxy, match: try RuleMatch(domainExact: "printer"))
let simpleSuffix = ProxyRule(action: .proxy, match: .domainSuffix("cn"))
let localProxy = ProxyRule(
action: .proxy, match: try RuleMatch(domainExact: "device.local"))
let localDirect = CustomRule(action: .direct, match: try RuleMatch(domainExact: "device.local"))
let nationalDirect = CustomRule(action: .direct, match: .domainSuffix("cn"))
let workflow = RulesWorkflow(
loadCustom: { [localDirect, nationalDirect] },
builtinSnapshots: BuiltinRuleSnapshots(loader: { requested in
rulesFixture(
requested, rules: requested == .gfwlist ? [simple, simpleSuffix, localProxy] : [])
}))
await workflow.refresh()
workflow.query(RulesQuery(source: .gfwlist))
let simpleRow = try XCTUnwrap(workflow.snapshot.rows.first { $0.identity == simple.identity })
XCTAssertEqual(simpleRow.fixedCoverage?.extent, .full)
let suffixRow = try XCTUnwrap(
workflow.snapshot.rows.first { $0.identity == simpleSuffix.identity })
XCTAssertEqual(suffixRow.fixedCoverage?.extent, .partial)
workflow.query(RulesQuery(source: .custom))
let localRow = try XCTUnwrap(
workflow.snapshot.rows.first { $0.identity == localDirect.identity })
XCTAssertEqual(localRow.fixedCoverage?.extent, .full)
XCTAssertFalse(localRow.relationships.contains { $0.kind == .shadowing })
let nationalRow = try XCTUnwrap(
workflow.snapshot.rows.first { $0.identity == nationalDirect.identity })
XCTAssertEqual(nationalRow.fixedCoverage?.extent, .partial)
XCTAssertTrue(
nationalRow.relationships.contains { $0.kind == .shadowing && $0.extent == .partial })
}
func testFullyFixedProtectedProxyDoesNotShadowAnUnprotectedDirectSuffix() async throws {
let direct = CustomRule(action: .direct, match: .domainSuffix("cn"))
let proxy = ProxyRule(action: .proxy, match: try RuleMatch(domainExact: "cn"))
let workflow = RulesWorkflow(
loadCustom: { [direct] },
builtinSnapshots: BuiltinRuleSnapshots(loader: { requested in
rulesFixture(requested, rules: requested == .gfwlist ? [proxy] : [])
}))
await workflow.refresh()
workflow.query(RulesQuery(source: .custom))
let row = try XCTUnwrap(workflow.snapshot.rows.first)
XCTAssertFalse(row.relationships.contains { $0.kind == .shadowing })
XCTAssertEqual(row.fixedCoverage?.extent, .partial)
}
}