Files
ShadowsocksX-NG/ShadowsocksX-NG2/Tests/Rules/OfflineRulesWorkflowTests.swift
T
Qiu YuzhouandDeepSeek Harness d63d04c114 test: drop matrix and ACL cases whose inputs never reach the unit
testExternalSettingsChangesNeverSupplyAFallbackOrAlterThreeStateResults
mutates a preferences fixture 12 ways but never passes it to RulesWorkflow
(which takes no preferences) and the matcher path is a pure function of the
collection; the 48 assertions are four matcher outcomes repeated 12 times and
each outcome is covered elsewhere.

The two ACL "does not load custom rules" cases build a customRules array that
ProxyACLDocument.global/direct cannot receive (both take only a URL), so their
contains() negatives could never fail; the template shapes are pinned by
ProxyACLTests and the behavioral claim by CustomRuleControllerTests.

Co-Authored-By: DeepSeek Harness <noreply@deepseek.com>
2026-10-21 01:19:15 +08:00

102 lines
4.7 KiB
Swift

import XCTest
@testable import ShadowsocksX_NG2
@MainActor
final class OfflineRulesWorkflowTests: XCTestCase {
func testAddressTestUsesCompleteSavedCollectionDespiteBrowsingFilters() async throws {
let rule = CustomRule(action: .proxy, match: try RuleMatch(domainSuffix: "example.com"))
let workflow = RulesWorkflow(
loadCustom: { [rule] }, builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
await workflow.refresh()
workflow.query(RulesQuery(search: "hidden", action: .direct, source: .chinaIPv4))
XCTAssertTrue(workflow.snapshot.rows.isEmpty)
workflow.setTestTarget("a.example.com")
await workflow.testAddress()
let result = try XCTUnwrap(workflow.snapshot.addressTest.result)
XCTAssertEqual(result.outcome, .proxy)
XCTAssertEqual(result.version, workflow.snapshot.version)
XCTAssertEqual(result.deciding.map(\.identity), [rule.identity])
XCTAssertTrue(result.domainWithoutDNS)
}
func testInvalidAndIncompleteCollectionsExposeOperationErrors() async throws {
let workflow = RulesWorkflow(
loadCustom: { [] }, builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
workflow.setTestTarget("example.com")
await workflow.testAddress()
XCTAssertEqual(workflow.snapshot.addressTest.failure, .incompleteCollection)
await workflow.refresh()
workflow.setTestTarget("https://")
await workflow.testAddress()
XCTAssertEqual(workflow.snapshot.addressTest.failure, .invalidTarget)
XCTAssertNil(workflow.snapshot.addressTest.result)
let incomplete = RulesWorkflow(
loadCustom: { [] },
builtinSnapshots: BuiltinRuleSnapshots(loader: { _ in throw RuleSnapshotError.missing }))
await incomplete.refresh()
incomplete.setTestTarget("localhost")
await incomplete.testAddress()
XCTAssertEqual(incomplete.snapshot.addressTest.failure, .incompleteCollection)
XCTAssertNil(incomplete.snapshot.addressTest.result)
}
func testPublicRefreshClearsOldResultAndUsesNewSavedVersion() async throws {
let directory = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
defer { try? FileManager.default.removeItem(at: directory) }
let store = CustomRuleStore(fileURL: directory.appendingPathComponent("rules.json"))
let proxy = CustomRule(action: .proxy, match: try RuleMatch(domainExact: "example.com"))
try store.save([proxy])
let workflow = RulesWorkflow(
loadCustom: { try store.load() },
builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
await workflow.refresh()
workflow.setTestTarget("example.com")
await workflow.testAddress()
let version = workflow.snapshot.addressTest.result?.version
try store.save([CustomRule(action: .direct, match: proxy.match)])
await workflow.refresh()
XCTAssertNil(workflow.snapshot.addressTest.result)
XCTAssertFalse(workflow.snapshot.addressTest.isTesting)
XCTAssertNotEqual(workflow.snapshot.version, version)
XCTAssertEqual(workflow.snapshot.addressTest.target, "example.com")
await workflow.testAddress()
XCTAssertEqual(workflow.snapshot.addressTest.result?.outcome, .direct)
try Data("broken".utf8).write(to: store.fileURL)
await workflow.refresh()
await workflow.testAddress()
XCTAssertEqual(workflow.snapshot.addressTest.failure, .incompleteCollection)
XCTAssertNil(workflow.snapshot.addressTest.result)
}
func testClearingTargetOrStartingRefreshPreventsLateTestPublication() async throws {
let rule = CustomRule(action: .proxy, match: try RuleMatch(domainSuffix: "example.com"))
let workflow = RulesWorkflow(
loadCustom: { [rule] }, builtinSnapshots: BuiltinRuleSnapshots(loader: { rulesFixture($0) }))
await workflow.refresh()
workflow.setTestTarget("example.com")
await workflow.testAddress()
workflow.setTestTarget("")
XCTAssertNil(workflow.snapshot.addressTest.result)
XCTAssertNil(workflow.snapshot.addressTest.failure)
// Queue a new public command as soon as the old test starts. The old
// detached task must not publish after that command invalidates its intent.
for refresh in [false, true] {
workflow.setTestTarget("example.com")
var invalidation: Task<Void, Never>?
let observation = workflow.$snapshot.sink { page in
guard page.addressTest.isTesting, invalidation == nil else { return }
invalidation = Task { @MainActor in
if refresh { await workflow.refresh() } else { workflow.setTestTarget("") }
}
}
await workflow.testAddress()
await invalidation?.value
observation.cancel()
XCTAssertNil(workflow.snapshot.addressTest.result)
XCTAssertFalse(workflow.snapshot.addressTest.isTesting)
}
}
}