From 1db5bfeab5f966a1f7c9f4222109c0d4903cb6a2 Mon Sep 17 00:00:00 2001
From: rioarray <rio.array@windowslive.com>
Date: Thu, 17 Oct 2019 14:45:30 +0700
Subject: [PATCH] inline conditional rendering in some components

---
 src/components/FilterItem/FilterItem.js | 4 +---
 src/components/Layout/Bread.js          | 4 +---
 src/components/Layout/Sider.js          | 6 +++---
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/components/FilterItem/FilterItem.js b/src/components/FilterItem/FilterItem.js
index b5c5c3f..e701c8b 100644
--- a/src/components/FilterItem/FilterItem.js
+++ b/src/components/FilterItem/FilterItem.js
@@ -6,7 +6,7 @@ const FilterItem = ({ label = '', children }) => {
   const labelArray = label.split('')
   return (
     <div className={styles.filterItem}>
-      {labelArray.length > 0 ? (
+      {labelArray.length > 0 && (
         <div className={styles.labelWrap}>
           {labelArray.map((item, index) => (
             <span className="labelText" key={index}>
@@ -14,8 +14,6 @@ const FilterItem = ({ label = '', children }) => {
             </span>
           ))}
         </div>
-      ) : (
-        ''
       )}
       <div className={styles.item}>{children}</div>
     </div>
diff --git a/src/components/Layout/Bread.js b/src/components/Layout/Bread.js
index 268890c..4cc80b8 100644
--- a/src/components/Layout/Bread.js
+++ b/src/components/Layout/Bread.js
@@ -14,9 +14,7 @@ class Bread extends PureComponent {
     return paths.map((item, key) => {
       const content = item && (
         <Fragment>
-          {item.icon ? (
-            <Icon type={item.icon} style={{ marginRight: 4 }} />
-          ) : null}
+          {item.icon && <Icon type={item.icon} style={{ marginRight: 4 }} />}
           {item.name}
         </Fragment>
       )
diff --git a/src/components/Layout/Sider.js b/src/components/Layout/Sider.js
index 2179aa1..26c3e8a 100644
--- a/src/components/Layout/Sider.js
+++ b/src/components/Layout/Sider.js
@@ -28,13 +28,13 @@ class Sider extends PureComponent {
         trigger={null}
         collapsible
         collapsed={collapsed}
-        onBreakpoint={isMobile ? null : onCollapseChange}
+        onBreakpoint={!isMobile && onCollapseChange}
         className={styles.sider}
       >
         <div className={styles.brand}>
           <div className={styles.logo}>
             <img alt="logo" src={config.logoPath} />
-            {collapsed ? null : <h1>{config.siteName}</h1>}
+            {!collapsed && <h1>{config.siteName}</h1>}
           </div>
         </div>
 
@@ -54,7 +54,7 @@ class Sider extends PureComponent {
             />
           </ScrollBar>
         </div>
-        {collapsed ? null : (
+        {!collapsed && (
           <div className={styles.switchTheme}>
             <span>
               <Icon type="bulb" />