From 0ee615ac6c5ebb3a35913126215453281072d575 Mon Sep 17 00:00:00 2001 From: Max Lv Date: Wed, 16 Dec 2015 17:05:49 +0800 Subject: [PATCH] Ensure the fragment is unregistered onPause It's quite tricky to avoid getActivity() returns null http://stackoverflow.com/questions/8914368/getactivity-return-null-in-preferencefragment --- src/main/scala/com/github/shadowsocks/ShadowsocksSettings.scala | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/scala/com/github/shadowsocks/ShadowsocksSettings.scala b/src/main/scala/com/github/shadowsocks/ShadowsocksSettings.scala index 7fba788b..46795624 100644 --- a/src/main/scala/com/github/shadowsocks/ShadowsocksSettings.scala +++ b/src/main/scala/com/github/shadowsocks/ShadowsocksSettings.scala @@ -118,6 +118,7 @@ class ShadowsocksSettings extends PreferenceFragment with OnSharedPreferenceChan override def onPause { super.onPause() + ShadowsocksApplication.settings.unregisterOnSharedPreferenceChangeListener(this) } def onSharedPreferenceChanged(sharedPreferences: SharedPreferences, key: String) = key match {