Fix a crash when reordering profiles

2017-12-06 23:25:54 -08:00
parent 8f14bc8846
commit 6608355e63
1 changed files with 2 additions and 2 deletions
@@ -244,10 +244,10 @@ class ProfilesFragment : ToolbarFragment(), Toolbar.OnMenuItemClickListener {

        fun move(from: Int, to: Int) {
            undoManager.flush()
-            val step = if (from < to) 1 else -1
            val first = profiles[from]
            var previousOrder = first.userOrder
-            for (i in if (from < to) from until to else from..to + 1 step -1) {
+            val (step, range) = if (from < to) Pair(1, from until to) else Pair(-1, to + 1 downTo from)
+            for (i in range) {
                val next = profiles[i + step]
                val order = next.userOrder
                next.userOrder = previousOrder