diff --git a/tests/test_local_api_cpp.cpp b/tests/test_local_api_cpp.cpp index 03e6dd28..525a975a 100644 --- a/tests/test_local_api_cpp.cpp +++ b/tests/test_local_api_cpp.cpp @@ -26,6 +26,7 @@ void on_ready(int socks_fd, int, void *) { ready_fd = socks_fd; } int free_port() { int fd = socket(AF_INET, SOCK_STREAM, 0); + SS_CHECK(fd >= 0); sockaddr_in a{}; a.sin_family = AF_INET; a.sin_addr.s_addr = htonl(INADDR_LOOPBACK); @@ -39,6 +40,9 @@ int free_port() bool socks_greeting(int port) { int fd = socket(AF_INET, SOCK_STREAM, 0); + if (fd < 0) { + return false; + } sockaddr_in a{}; a.sin_family = AF_INET; a.sin_port = htons(static_cast(port)); diff --git a/tests/test_resolver_cpp.cpp b/tests/test_resolver_cpp.cpp index 348c45d6..6a16b3f5 100644 --- a/tests/test_resolver_cpp.cpp +++ b/tests/test_resolver_cpp.cpp @@ -24,8 +24,8 @@ namespace { struct Answered { unsigned called = 0; - bool missing = false; int family = 0; + bool missing = false; bool ok = false; }; @@ -138,6 +138,7 @@ void test_answers_and_limits() SS_CHECK(loop.init()); test_loop = &loop; int fd = socket(AF_INET, SOCK_DGRAM, 0); + SS_CHECK(fd >= 0); sockaddr_in a{}; a.sin_family = AF_INET; a.sin_addr.s_addr = htonl(INADDR_LOOPBACK);