Some code improvements

* Rewrite empty string checks more idiomatically.
* Change strings.ToLower comparisons to strings.EqualFold.
* Rewrite switch statement with only one case as if.
This commit is contained in:
Kirill Motkov
2019-06-28 17:53:44 +03:00
parent 4c93d36d49
commit 0401a91ef4
26 changed files with 38 additions and 39 deletions
+1 -1
View File
@@ -167,7 +167,7 @@ func (h *Handler) AddUser(ctx context.Context, user *protocol.MemoryUser) error
}
func (h *Handler) RemoveUser(ctx context.Context, email string) error {
if len(email) == 0 {
if email == "" {
return newError("Email must not be empty.")
}
if !h.usersByEmail.Remove(email) {
+1 -1
View File
@@ -149,7 +149,7 @@ func (v *TimedUserValidator) Remove(email string) bool {
email = strings.ToLower(email)
idx := -1
for i, u := range v.users {
if strings.ToLower(u.user.Email) == email {
if strings.EqualFold(u.user.Email, email) {
idx = i
break
}