Alawn/Druid
1
0
Fork 0
mirror of https://github.com/alibaba/druid.git synced 2023-03-04 19:17:16 +00:00
Code Issues Releases Wiki Activity

refactor

Browse Source
This commit is contained in:
温少
2012-03-17 23:12:48 +08:00
parent 2ba9e19a0f
commit e4f45cd23c
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/alibaba/druid/filter/wall/WallProvider.java
+10 -12
View File
@@ -6,7 +6,7 @@ import java.util.LinkedHashMap;
import java.util.List;
import com.alibaba.druid.sql.ast.SQLStatement;
import com.alibaba.druid.sql.parser.NotAllowCommentException;
import com.alibaba.druid.sql.parser.ParserException;
import com.alibaba.druid.sql.parser.SQLStatementParser;
import com.alibaba.druid.sql.parser.Token;
@@ -51,11 +51,6 @@ public abstract class WallProvider {
public abstract WallVisitor createWallVisitor();
public boolean check(String sql, boolean throwException) throws WallRuntimeException {
List<Violation> violations = check(sql);
return violations.size() > 0;
}
public List<Violation> check(String sql) {
// first step, check whiteList
boolean isWhite = whiteContains(sql);
@@ -63,7 +58,6 @@ public abstract class WallProvider {
return Collections.emptyList();
}
SQLStatementParser parser = createParser(sql);
parser.getLexer().setAllowComment(false); // permit comment
@@ -71,23 +65,27 @@ public abstract class WallProvider {
try {
parser.parseStatementList(statementList);
} catch (NotAllowCommentException e) {
return Collections.<Violation>singletonList(new IllegalSQLObjectViolation(sql));
} catch (ParserException e) {
return Collections.<Violation> singletonList(new IllegalSQLObjectViolation(sql));
}
if (parser.getLexer().token() != Token.EOF) {
return Collections.<Violation>singletonList(new IllegalSQLObjectViolation(sql));
return Collections.<Violation> singletonList(new IllegalSQLObjectViolation(sql));
}
if (statementList.size() > 1) {
return Collections.<Violation>singletonList(new IllegalSQLObjectViolation(sql));
return Collections.<Violation> singletonList(new IllegalSQLObjectViolation(sql));
}
SQLStatement stmt = statementList.get(0);
WallVisitor visitor = createWallVisitor();
stmt.accept(visitor);
try {
stmt.accept(visitor);
} catch (ParserException e) {
return Collections.<Violation> singletonList(new IllegalSQLObjectViolation(sql));
}
if (visitor.getViolations().size() == 0) {
if (sql.length() < whiteSqlMaxLength) {