Do not return empty list if raise exception

2016-11-24 19:13:32 +08:00
parent d45ba8de03
commit e048e224d0
1 changed files with 4 additions and 5 deletions
@@ -314,8 +314,9 @@ class DbTransfer(TransferBase):
 		except Exception as e:
 			logging.error(e)
 			update_transfer = {}
+		finally:
+			conn.close()

-		conn.close()
 		return update_transfer

 	def pull_db_all_user(self):
@@ -333,10 +334,8 @@ class DbTransfer(TransferBase):

 		try:
 			rows = self.pull_db_users(conn)
-		except Exception as e:
-			logging.error(e)
-			rows = []
-		conn.close()
+		finally:
+			conn.close()

 		if not rows:
 			logging.warn('no user in db')