Files
ShadowsocksX-NG/ShadowsocksX-NG2/Tests/Workspace/HomeServerListStateTests.swift
T
Qiu Yuzhou 20a62117f2 refactor(tests): 按功能领域重组 Tests/ 目录
Tests/ 根层原有 138 个平铺测试文件,无法从目录读出测试覆盖的功能领域。

按功能领域重组为 17 个目录(Catalog/Workflow 与 Rules/Custom 两处嵌套,分别
对应 App/Application/CatalogWorkflow 与 Domain/Rules/Custom):Architecture /
Support / Agent / Activation / Catalog / Subscription / Rules / ProxyRuntime /
ProxyControl / Runtime / Settings / SystemProxy / Plugin / Diagnostics /
Credentials / Workspace / Servers;Smoke/ 保持独立 target 不动。138 个移动中
132 个是 100% 相似度的纯重命名,其余 6 个在重命名之上带路径反推改写(见下)。

本次不是纯搬移:测试代码比生产代码多一层位置耦合,有 7 处用固定层数的
deletingLastPathComponent() 从 #filePath 反推仓库路径(都假定文件就在 Tests/
根层)。这 7 处改走新增的 Tests/Support/TestSourceTree.swift——从调用点沿父
目录上溯找到含 project.yml 的目录,因此不再依赖父目录层数,以后移动测试文件
也不会静默指错。

配套改动:

- 新增 Tests 布局守卫 TestsLayoutTests,断言 Tests/ 根层无平铺 .swift。比
  Domain 那条弱一档——根层的 Info.plist(info.path 生成物)与
  Fixtures/RuleSnapshots 下的 JSON(folder resource)都必须保留,不能用
  「树下只有 .swift」覆盖。
- project.yml:Smoke target 按文件引用的 Tests/AppArtifact.swift 改指
  Tests/Support/;两处注释里写死的 Tests/SkeletonTests.swift 随移动更新。
  excludes 的裸名 "Smoke" / "Fixtures" 仍匹配 Tests/ 直属子目录,无需改动。
- README 的 Tests 条目展开为目录说明,并修掉 Domain 条目里写死的
  Tests/SkeletonTests.swift。
- 顺带删去 DomainLayoutTests 文档注释里「整理前 62 个文件」这类易漂移的数字。

验证:xcodegen generate 后单测 target 为 139 个源文件(全部非 Smoke 文件,0 个
Smoke 文件混入)且仍以 Fixtures/RuleSnapshots 为资源,Smoke target 为 8 个
Smoke 文件加 AppArtifact;依赖路径反推的 6 个测试类全绿(路径指错即失败);
task format 未改写任何被移动文件;task lint 与整理前同为 21 条内容型 warning;
build 0 error;task test 1025 用例全通过(整理前 1024,+1 为新守卫);
TestsLayoutTests 经变异验证(根层投放探针即失败);packaging-gate ALL CHECKS
PASSED。
2026-10-05 20:37:35 +08:00

149 lines
6.3 KiB
Swift

import XCTest
@testable import ShadowsocksX_NG2
@MainActor
final class HomeServerListStateTests: XCTestCase {
private var defaults: UserDefaults!
private var suiteName: String!
override func setUp() async throws {
suiteName = "HomeServerListStateTests.\(UUID().uuidString)"
defaults = try XCTUnwrap(UserDefaults(suiteName: suiteName))
}
override func tearDown() async throws {
defaults.removePersistentDomain(forName: suiteName)
defaults = nil
}
func testTreePreservesRootOrderAndPureContainerGroups() {
let state = HomeServerListState(defaults: defaults)
let tree = fixtureTree()
state.update(tree: tree, activeTargetID: nil)
XCTAssertEqual(
state.visibleRows.map(\.id.rawValue), ["root-server", "outer", "inner", "empty"])
XCTAssertEqual(state.visibleRows.map(\.depth), [0, 0, 1, 0])
state.toggleGroup(id("inner"))
XCTAssertEqual(
state.visibleRows.map(\.id.rawValue),
["root-server", "outer", "inner", "leaf", "invalid", "empty"])
XCTAssertNil(state.selection)
}
private func id(_ value: String) -> NodeID { NodeID(rawValue: value) }
func testExpansionRestoresAcrossRestartWithoutAffectingManagement() {
let state = HomeServerListState(defaults: defaults)
state.update(tree: fixtureTree(), activeTargetID: nil)
state.toggleGroup(id("inner"))
state.toggleGroup(id("outer"))
let restarted = HomeServerListState(defaults: defaults)
restarted.update(tree: fixtureTree(), activeTargetID: id("leaf"))
XCTAssertEqual(restarted.visibleRows.map(\.id.rawValue), ["root-server", "outer", "empty"])
restarted.toggleGroup(id("outer"))
XCTAssertEqual(
restarted.visibleRows.map(\.id.rawValue),
["root-server", "outer", "inner", "leaf", "invalid", "empty"])
XCTAssertFalse(CatalogExpansionState().isCollapsed(id("outer")))
}
private func fixtureTree() -> CatalogTreeSnapshot {
let leaf = node("leaf", parent: "inner")
let invalid = node("invalid", parent: "inner", invalid: true)
let inner = node("inner", parent: "outer", children: [leaf, invalid])
return CatalogTreeSnapshot(roots: [
node("root-server"), node("outer", children: [inner]), node("empty", children: []),
])
}
func testSelectionAndLocateDoNotImplicitlyFollowActivationChanges() {
let state = HomeServerListState(defaults: defaults)
state.update(tree: fixtureTree(), activeTargetID: id("leaf"))
XCTAssertEqual(state.selection, id("leaf"))
XCTAssertFalse(state.visibleRows.map(\.id).contains(id("leaf")))
state.select(id("root-server"))
state.update(tree: fixtureTree(), activeTargetID: id("inner"))
XCTAssertEqual(state.selection, id("root-server"))
state.toggleGroup(id("outer"))
state.locate(id("leaf"))
XCTAssertEqual(state.selection, id("leaf"))
XCTAssertTrue(state.visibleRows.map(\.id).contains(id("leaf")))
state.toggleGroup(id("inner"))
XCTAssertEqual(state.selection, id("inner"))
state.update(tree: CatalogTreeSnapshot(roots: [node("root-server")]), activeTargetID: nil)
XCTAssertNil(state.selection)
}
private func node(
_ value: String, parent: String? = nil, children: [CatalogTreeNode]? = nil,
invalid: Bool = false
) -> CatalogTreeNode {
CatalogTreeNode(
id: id(value), name: value, isGroup: children != nil, source: .manual,
parentID: parent.map(id),
invalidReasons: invalid ? [.unsupportedEncryptionMethod("future-cipher")] : [],
childCount: children?.count ?? 0,
subtreeNodeCount: children?.reduce(0) { $0 + 1 + $1.subtreeNodeCount } ?? 0,
invalidDescendantCount: children?.reduce(0) { $0 + $1.subtreeInvalidServerCount } ?? 0,
children: children)
}
func testKeyboardNavigationUsesVisibleRowsAndTreeRelationships() {
let state = HomeServerListState(defaults: defaults)
state.update(tree: fixtureTree(), activeTargetID: nil)
state.navigate(.downward)
XCTAssertEqual(state.selection, id("root-server"))
state.navigate(.downward)
state.navigate(.right)
XCTAssertEqual(state.selection, id("inner"))
state.navigate(.right)
XCTAssertEqual(state.selection, id("inner"), "首次右键只展开")
state.navigate(.right)
XCTAssertEqual(state.selection, id("leaf"))
state.navigate(.left)
XCTAssertEqual(state.selection, id("inner"))
state.navigate(.left)
state.navigate(.downward)
XCTAssertEqual(state.selection, id("empty"), "跳过隐藏成员")
state.navigate(.downward)
XCTAssertEqual(state.selection, id("empty"))
state.navigate(.upward)
XCTAssertEqual(state.selection, id("inner"))
}
func testOnlySelectedVisibleEligibleNonActiveTargetCanBeActivated() {
let state = HomeServerListState(defaults: defaults)
state.update(tree: fixtureTree(), activeTargetID: id("leaf"))
let eligible = ActivationEligibility(
canActivate: true, candidateCount: 1, skippedInvalidCount: 0, ineligibility: nil)
XCTAssertNil(state.activationTarget(activeTargetID: nil, eligibility: eligible))
state.select(id("root-server"))
XCTAssertEqual(
state.activationTarget(activeTargetID: id("outer"), eligibility: eligible), id("root-server"))
XCTAssertNil(state.activationTarget(activeTargetID: id("root-server"), eligibility: eligible))
let unavailable = ActivationEligibility(
canActivate: false, candidateCount: 0, skippedInvalidCount: 1, ineligibility: .noCandidates)
XCTAssertNil(state.activationTarget(activeTargetID: nil, eligibility: unavailable))
XCTAssertNil(state.activationTarget(activeTargetID: nil, eligibility: nil))
}
func testMovedSelectionFollowsVisibleAncestorAndActiveMarksKeepTargetIdentity() {
let state = HomeServerListState(defaults: defaults)
state.update(tree: fixtureTree(), activeTargetID: nil)
state.select(id("root-server"))
let moved = node("root-server", parent: "inner")
let inner = node("inner", parent: "outer", children: [moved])
state.update(
tree: CatalogTreeSnapshot(roots: [node("outer", children: [inner])]),
activeTargetID: id("inner"))
XCTAssertEqual(state.selection, id("inner"))
XCTAssertEqual(state.ancestorIDs(for: id("inner")), [id("outer")])
XCTAssertEqual(state.ancestorIDs(for: id("root-server")), [id("inner"), id("outer")])
state.locate(id("inner"))
XCTAssertFalse(state.visibleRows.map(\.id).contains(id("root-server")), "定位组不展开组自身")
}
}