Check server IP address validity and log it

Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
2016-08-09 08:32:16 +08:00
parent 93e7641446
commit 4fcddc3e82
1 changed files with 4 additions and 2 deletions
@@ -42,7 +42,9 @@ namespace Shadowsocks.Model
                return I18N.GetString("New server");
            }
            IPAddress addr;
-            IPAddress.TryParse( server, out addr );
+            if ( !IPAddress.TryParse( server, out addr ) ) {
+                Logging.Error( "Invalid server IP Address" );
+            }
            if ( remarks.IsNullOrEmpty() ) {
                switch ( addr.AddressFamily ) {
                    case AddressFamily.InterNetwork:
@@ -58,7 +60,7 @@ namespace Shadowsocks.Model
                        return $"{remarks} ([{server}]:{server_port})";
                }
            }
-            // This should not happen, user should check the input instead of blaming
+            // If reached here, boom.
            return null;
        }