Issue #16 更新Sonar規則，但取消mvn site的report了，實在和Sonar差太遠.

examples/mini-service/src/main/java/org/springside/examples/miniservice/webservice/rs/client/AccountResourceClient.java

@@ -12,6 +12,7 @@ import org.springside.examples.miniservice.webservice.dto.UserDTO;
 import org.springside.modules.rest.jersey.Jerseys;
 
 import com.sun.jersey.api.client.ClientResponse;
+import com.sun.jersey.api.client.ClientResponse.Status;
 import com.sun.jersey.api.client.GenericType;
 import com.sun.jersey.api.client.UniformInterfaceException;
 import com.sun.jersey.api.client.WebResource;
@@ -64,9 +65,9 @@ public class AccountResourceClient {
 	 * 创建用户, 使用Post发送JSON编码的用户对象, 返回代表用户的url.
 	 */
 	public URI createUser(UserDTO user) {
-		ClientResponse response = client.path("/users").entity(user, MediaType.APPLICATION_JSON).post(
-				ClientResponse.class);
-		if (201 == response.getStatus()) {
+		ClientResponse response = client.path("/users").entity(user, MediaType.APPLICATION_JSON)
+				.post(ClientResponse.class);
+		if (Status.CREATED.getStatusCode() == response.getStatus()) {
 			return response.getLocation();
 		} else {
 			throw new UniformInterfaceException(response);

examples/mini-web/src/main/java/org/springside/examples/miniweb/entity/account/Permission.java

@@ -15,9 +15,10 @@ public enum Permission {
 
 	GROUP_VIEW("group:view", "查看权限组"), GROUP_EDIT("group:edit", "修改权限组");
 
+	private static Map<String, Permission> valueMap = Maps.newHashMap();
+
 	public String value;
 	public String displayName;
-	private static Map<String, Permission> valueMap = Maps.newHashMap();
 
 	static {
 		for (Permission permission : Permission.values()) {

examples/showcase/src/main/java/org/springside/examples/showcase/webservice/rs/server/UserResourceService.java

@@ -127,6 +127,7 @@ public class UserResourceService {
 		}
 
 		if (userName == null) {
+			//抛出自定义的异常450
 			throw Jerseys.buildException(450, "用戶名既不在Http Header也不在URL参数中");
 		}
 

modules/core/src/main/java/org/springside/modules/mapper/BeanMapper.java

@@ -19,14 +19,14 @@ import com.google.common.collect.Lists;
  */
 public class BeanMapper {
 
-	private BeanMapper() {
-	}
-
 	/**
 	 * 持有Dozer单例, 避免重复创建DozerMapper消耗资源.
 	 */
 	private static DozerBeanMapper dozer = new DozerBeanMapper();
 
+	private BeanMapper() {
+	}
+
 	/**
 	 * 基于Dozer转换对象的类型.
 	 */

modules/core/src/main/java/org/springside/modules/test/data/H2Fixtures.java

@@ -33,12 +33,12 @@ import org.springside.modules.utils.Exceptions;
  */
 public class H2Fixtures {
 
-	private H2Fixtures() {
-	}
-
 	private static Logger logger = LoggerFactory.getLogger(H2Fixtures.class);
 	private static ResourceLoader resourceLoader = new DefaultResourceLoader();
 
+	private H2Fixtures() {
+	}
+
 	/**
 	 * 插入XML文件中的数据到数据库.
 	 *  
@@ -108,9 +108,9 @@ public class H2Fixtures {
 	public static void deleteAllTable(DataSource dataSource, String... excludeTables) {
 
 		List<String> tableNames = new ArrayList<String>();
+		ResultSet rs = null;
 		try {
-			ResultSet rs = dataSource.getConnection().getMetaData()
-					.getTables(null, null, null, new String[] { "TABLE" });
+			rs = dataSource.getConnection().getMetaData().getTables(null, null, null, new String[] { "TABLE" });
 			while (rs.next()) {
 				String tableName = rs.getString("TABLE_NAME");
 				if (Arrays.binarySearch(excludeTables, tableName) < 0) {
@@ -118,11 +118,17 @@ public class H2Fixtures {
 				}
 			}
 
-			rs.close();
-
 			deleteTable(dataSource, tableNames.toArray(new String[tableNames.size()]));
 		} catch (SQLException e) {
 			Exceptions.unchecked(e);
+		} finally {
+			if (rs != null) {
+				try {
+					rs.close();
+				} catch (SQLException e) {
+					e.printStackTrace();
+				}
+			}
 		}
 
 	}

modules/core/src/main/java/org/springside/modules/utils/Identities.java

@@ -21,14 +21,14 @@ public class Identities {
 	}
 
 	/**
-	 * 封装JDK自带的UUID, 通过Random数字生成,中间有-分割
+	 * 封装JDK自带的UUID, 通过Random数字生成, 中间有-分割.
 	 */
 	public static String uuid() {
 		return UUID.randomUUID().toString();
 	}
 
 	/**
-	 * 封装JDK自带的UUID, 通过Random数字生成,中间无-分割
+	 * 封装JDK自带的UUID, 通过Random数字生成, 中间无-分割.
 	 */
 	public static String uuid2() {
 		return UUID.randomUUID().toString().replaceAll("-", "");

modules/parent/pom.xml

@@ -919,56 +919,7 @@
 					<version>1.7</version>
 				</plugin>
 				
-				<plugin>
-        			<groupId>org.apache.maven.plugins</groupId>
-        			<artifactId>maven-site-plugin</artifactId>
-        			<version>3.0</version>
-        			<configuration>
-    					<reportPlugins>
-						    <plugin>
-						        <groupId>org.apache.maven.plugins</groupId>
-						        <artifactId>maven-jxr-plugin</artifactId>
-						        <version>2.3</version>
-						    </plugin>
-    						<plugin>
-								<groupId>org.apache.maven.plugins</groupId>
-								<artifactId>maven-checkstyle-plugin</artifactId>
-								<version>2.9.1</version>
-								<configuration>
-									<configLocation>../../support/sonar/springside-checkstyle.xml</configLocation>
-								</configuration>
-				  			</plugin>
-				  			<plugin>
-						        <groupId>org.apache.maven.plugins</groupId>
-						        <artifactId>maven-pmd-plugin</artifactId>
-						        <version>2.7.1</version>
-						        <configuration>
-							    	<targetJdk>${jdk.version}</targetJdk>
-							        <rulesets><ruleset>../../support/sonar/springside-pmd.xml</ruleset></rulesets>
-							        <formats><format>html</format></formats>
-						        </configuration>
-						    </plugin>
-						    <plugin>
-					            <groupId>org.codehaus.mojo</groupId>
-					            <artifactId>cobertura-maven-plugin</artifactId>
-					            <version>2.5.1</version>
-					            <configuration>
-					              	<formats><format>html</format></formats>
-					            </configuration>
-					        </plugin>
-					        <plugin>
-							    <groupId>org.codehaus.mojo</groupId>
-	        					<artifactId>findbugs-maven-plugin</artifactId>
-	        					<version>2.4.0</version>
-	        					<configuration>
-	        						<includeFilterFile>../../support/sonar/springside-findbugs.xml</includeFilterFile>
-	        						<formats><format>html</format></formats> 
-	        					</configuration>
-      						</plugin>
-						</reportPlugins>
-        			</configuration>
-        		</plugin>
-        		
+				<!-- sonar插件 -->
         		<plugin>
         		 	<groupId>org.codehaus.mojo</groupId>
         		 	<artifactId>sonar-maven-plugin</artifactId>

support/sonar/springside-checkstyle.xml

@@ -1 +1 @@
-<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd"><!-- Generated by Sonar --><module name="Checker"><module name="SuppressionCommentFilter"/><module name="TreeWalker"><module name="FileContentsHolder"/> <module name="CyclomaticComplexity"><property name="severity" value="warning"/><property name="max" value="10"/></module><module name="DoubleCheckedLocking"><property name="severity" value="warning"/></module><module name="HiddenField"><property name="severity" value="warning"/><property name="tokens" value="VARIABLE_DEF"/><property name="ignoreConstructorParameter" value="true"/><property name="ignoreSetter" value="true"/><property name="ignoreAbstractMethods" value="true"/></module><module name="StringLiteralEquality"><property name="severity" value="warning"/></module><module name="LocalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="RedundantModifier"><property name="severity" value="info"/></module><module name="IllegalThrows"><property name="severity" value="warning"/></module><module name="AnonInnerLength"><property name="severity" value="warning"/></module><module name="StaticVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="ParameterName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MethodName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="allowClassName" value="false"/></module><module name="DefaultComesLast"><property name="severity" value="warning"/></module><module name="LocalFinalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MemberName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="EqualsHashCode"><property name="severity" value="error"/></module><module name="VisibilityModifier"><property name="severity" value="warning"/><property name="protectedAllowed" value="true"/></module><module name="EmptyStatement"><property name="severity" value="info"/></module><module name="PackageName"><property name="severity" value="warning"/><property name="format" value="^[a-z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)*$"/></module><module name="ConstantName"><property name="severity" value="info"/><property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="RedundantThrows"><property name="severity" value="info"/></module><module name="ParameterAssignment"><property name="severity" value="warning"/></module><module name="UnusedImports"><property name="severity" value="info"/><property name="processJavadoc" value="false"/></module><module name="SimplifyBooleanExpression"><property name="severity" value="warning"/></module><module name="HideUtilityClassConstructor"><property name="severity" value="warning"/></module><module name="SimplifyBooleanReturn"><property name="severity" value="warning"/></module><module name="ModifierOrder"><property name="severity" value="info"/></module><module name="BooleanExpressionComplexity"><property name="severity" value="warning"/></module><module name="InnerAssignment"><property name="severity" value="warning"/></module><module name="MagicNumber"><property name="severity" value="info"/><property name="ignoreHashCodeMethod" value="false"/><property name="ignoreAnnotation" value="false"/></module></module></module>
+<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd"><!-- Generated by Sonar --><module name="Checker"><module name="SuppressionCommentFilter"/><module name="TreeWalker"><module name="FileContentsHolder"/> <module name="CyclomaticComplexity"><property name="severity" value="warning"/><property name="max" value="10"/></module><module name="ModifiedControlVariable"><property name="severity" value="warning"/></module><module name="DoubleCheckedLocking"><property name="severity" value="warning"/></module><module name="HiddenField"><property name="severity" value="warning"/><property name="tokens" value="VARIABLE_DEF"/><property name="ignoreConstructorParameter" value="true"/><property name="ignoreSetter" value="true"/><property name="ignoreAbstractMethods" value="true"/></module><module name="StringLiteralEquality"><property name="severity" value="warning"/></module><module name="NestedForDepth"><property name="severity" value="warning"/><property name="max" value="3"/></module><module name="LocalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="JavaNCSS"><property name="severity" value="warning"/><property name="classMaximum" value="500"/><property name="fileMaximum" value="600"/></module><module name="RedundantModifier"><property name="severity" value="info"/></module><module name="IllegalThrows"><property name="severity" value="warning"/></module><module name="AnonInnerLength"><property name="severity" value="warning"/></module><module name="StaticVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="DeclarationOrder"><property name="severity" value="info"/></module><module name="ParameterName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MethodName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="allowClassName" value="false"/></module><module name="DefaultComesLast"><property name="severity" value="warning"/></module><module name="LocalFinalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MemberName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="EqualsHashCode"><property name="severity" value="error"/></module><module name="VisibilityModifier"><property name="severity" value="info"/><property name="protectedAllowed" value="true"/></module><module name="EmptyStatement"><property name="severity" value="info"/></module><module name="PackageName"><property name="severity" value="warning"/><property name="format" value="^[a-z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)*$"/></module><module name="ConstantName"><property name="severity" value="info"/><property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="RedundantThrows"><property name="severity" value="info"/><property name="allowUnchecked" value="true"/></module><module name="ParameterAssignment"><property name="severity" value="warning"/></module><module name="UnusedImports"><property name="severity" value="info"/><property name="processJavadoc" value="false"/></module><module name="SimplifyBooleanExpression"><property name="severity" value="warning"/></module><module name="HideUtilityClassConstructor"><property name="severity" value="warning"/></module><module name="SimplifyBooleanReturn"><property name="severity" value="warning"/></module><module name="ModifierOrder"><property name="severity" value="info"/></module><module name="BooleanExpressionComplexity"><property name="severity" value="warning"/></module><module name="InnerAssignment"><property name="severity" value="warning"/></module><module name="MagicNumber"><property name="severity" value="info"/><property name="ignoreHashCodeMethod" value="false"/><property name="ignoreAnnotation" value="false"/></module></module></module>

support/sonar/springside-findbugs.xml

@@ -757,9 +757,6 @@
   <Match>
     <Bug pattern="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE"/>
   </Match>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP"/>
-  </Match>
   <Match>
     <Bug pattern="JLM_JSR166_LOCK_MONITORENTER"/>
   </Match>